Hi, I have several remarks.

There's a potential for an endless loop in not so unrealistic
conditions.

Every other error besides ERANGE causes this. E.g. referencing a non-
existent group. Others can be caused by missing permissions, wrong
configuration in /etc/nsswitch.conf, etc.

Attached is a patch that should mitigate this. Manpages are a bit
ambiguous about how getgrnam_r() reports errors, but it looks safe to
ignore errno completely and rely on the return code.

The patch is for 5.10.2 but the code in v7 is almost identical.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/933943

Title:
  rsyslogd please apply patch for large group handling

To manage notifications about this bug go to:
https://bugs.launchpad.net/rsyslog/+bug/933943/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to