Chris, I'm accepting this into precise-proposed because from Colin I
understand re-validating a prospective patch is quite time-consuming
with a long customer round-trip. But the patch here is suboptimal; in
future SRUs, please avoid code changes unrelated to the bugs you're
trying to fix.
In this case, there are:
- renamed members in a class (m_nReqRangeFrom, m_nReqRangeTo)
- an API change that affects parsing behavior when an option appears more than
once in the config, which is unrelated to the bugs here (SetOption)
- renamed defines (EFLAG_DISCON, EFLAG_DO_DISCON)
- logging changes
All of these are unrelated to the bugfixes, and make code review of the
diff more time-consuming and error-prone. I've satisfied myself that
they're reasonably safe here, but such changes should not be included in
an SRU - an SRU should include the minimal change necessary to fix the
bug.
** Changed in: apt-cacher-ng (Ubuntu Precise)
Status: In Progress => Fix Committed
** Tags added: verification-needed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1162876
Title:
apt-cacher-ng data corruption with HTTP headers
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-cacher-ng/+bug/1162876/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
