** Description changed: - - duply does not check the return status of pre and post scripts and therefore returns 0 even if there was a problem in the pre/post scripts which returned an error. + duply does not check the return status of pre and post scripts and + therefore returns 0 even if there was a problem in the pre/post scripts + which returned an error. This issue happens every time and is 100% reproducible SRU Justification: [Impact] - * When using duply, errors on pre/post scripts are not caught and + * When using duply, errors on pre/post scripts are not caught and therefore succeed even if there were problems. [Test Case] - * Set up duply - * Create a pre script containing simply 'exit 1' inside it. - * Run 'duply srv pre' - * See duply succeed and return 0 + * Set up duply + * Create a pre script containing simply 'exit 1' inside it. + * Run 'duply srv pre' + * See duply succeed and return 0 --- Start running command PRE at 12:58:29.630 --- Running '/root/.duply/srv/pre' - FAILED (code 1) --- Finished state OK at 12:58:29.638 - Runtime 00:00:00.008 --- root@nas:~# echo $? 0 with the patch: --- Start running command PRE at 13:02:03.643 --- Running '/root/.duply/srv/pre' - FAILED (code 1) 13:02:03.652 Task 'PRE' failed with exit code '1'. --- Finished state FAILED 'code 1' at 13:02:03.652 - Runtime 00:00:00.009 --- root@nas:~# echo $? 1 [Regression Potential] - * The patch is minimal and has been accepted/committed upstream. - * This package has been tested on a virtual machine with the test case above and showed the right exit value. Minimal likelihood of regressions. + * The patch is minimal and has been accepted/committed upstream. + * This package has been tested on a virtual machine with the test case above and showed the right exit value. Minimal likelihood of regressions. ---- Status: - * Patch is the same as: - * http://sourceforge.net/tracker/index.php?func=detail&aid=3609075&group_id=217745&atid=1041147 - * Packages agains precise: https://launchpad.net/~edamato/+archive/lp1163905 + * Patch is the same as: + * http://sourceforge.net/tracker/index.php?func=detail&aid=3609075&group_id=217745&atid=1041147
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1163905 Title: Backport-Request: Failure in Duply's pre-scripts are muted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/duply/+bug/1163905/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
