Thanks for the patch.  My guess would be it was applied in the package
source, but not in the bzr tree, so after the next bzr tree update the
fix was lost.  But I'm not sure.

Patch pushed to bzr and to the saucy tree.  There are vmbuilder packages
awaiting verification in all the prior releases except lucid, so we
can't push SRU for this right now.

** Description changed:

+ =====================
+ Impact: specified macaddrs are ignored when using a bridge
+ Development fix: always specify the mac addr when it has been specified
+ Stable fix: same as development fix
+ Regression potential: if misapplied, networking for vmbuilder-built guests 
could be wrong.
+ Test case: build a vm using '--bridge br0 --max <somemac>' and check the 
resulting .xml
+ ======================
+ 
  On Jaunty 9.04
  
  When using Bridge networking and specifying --bridge br0, vmbuilder
  ignores the --mac option.
  
  Here is a patch:
  --- /etc/vmbuilder/libvirt/libvirtxml.tmpl.org  2009-06-25 13:57:55.000000000 
+0200
  +++ /etc/vmbuilder/libvirt/libvirtxml.tmpl      2009-06-25 13:58:16.000000000 
+0200
  @@ -20,11 +20,11 @@
-        <source bridge='$bridge'/>
-  #else
-      <interface type='network'>
+        <source bridge='$bridge'/>
+  #else
+      <interface type='network'>
  +      <source network='default'/>
  +#end if
-  #if $mac
-        <mac address='$mac'/>
-  #end if
+  #if $mac
+        <mac address='$mac'/>
+  #end if
  -      <source network='default'/>
  -#end if
-  #if $virtio_net
-        <model type='virtio'/>
-  #end if
- 
+  #if $virtio_net
+        <model type='virtio'/>
+  #end if
  
  Jarl

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/392097

Title:
  vmbuilder ignores mac option when using bridge network

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/392097/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to