---

Hi Yaroslav,

the patch below should fix the Oops caused by sd_start() called too early, but
I am not sure about why sd_start() was called from sd_init() for Hercules
webcams in the first place, maybe the snippet marked with:

  /* (from ms-win trace) */

in sd_start() must be moved to sd_init() too.

Let me know if the change below alone is enough and the webcam keeps working,
a test with suspend and resume would good to have too.

Thanks,
   Antonio

 drivers/media/usb/gspca/ov534.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/usb/gspca/ov534.c b/drivers/media/usb/gspca/ov534.c
index 2e28c81..03a33c4 100644
--- a/drivers/media/usb/gspca/ov534.c
+++ b/drivers/media/usb/gspca/ov534.c
@@ -1305,8 +1305,7 @@ static int sd_init(struct gspca_dev *gspca_dev)
        ov534_set_led(gspca_dev, 1);
        sccb_w_array(gspca_dev, sensor_init[sd->sensor].val,
                        sensor_init[sd->sensor].len);
-       if (sd->sensor == SENSOR_OV767x)
-               sd_start(gspca_dev);
+
        sd_stopN(gspca_dev);
 /*     set_frame_rate(gspca_dev);      */
 
-- 
1.8.4.rc1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1173723

Title:
  06f8:3002 BUG: unable to handle kernel NULL pointer dereference at
  0000000000000050; RIP: 0010:[<ffffffffa046ada1>] [<ffffffffa046ada1>]
  v4l2_ctrl_g_ctrl+0x11/0x60 [videodev]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1173723/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to