As for the lxlock from https://launchpad.net/~lubuntu- dev/+archive/staging, "xscreensaver-command -lock" at line 27 is redundant.
The script will fail, if gnome-screensaver is running and xscreensaver is not running, when you run lxlock. Running which gnome-screensaver-command >/dev/null && gnome-screensaver-command --exit >/dev/null 2>&1 before starting xscreensaver daemon in the script fixes that. When lxlock starts xscreensaver daemon, the xscreensaver daemon will be running the rest of the session, if it is not terminated explicitly. I think that is not a problem, but maybe it would be better to start xscreensaver daemon at startup anyway to give contiguous user experience. If gnome-screensaver is installed, it will be used by xfce4-power- manager, even if xscreensaver is running. Would it be good to prefer gnome-screensaver in lxlock, too? I wonder what is the reason to keep xlock in the script, as the xlockmore package has not been available in Ubuntu packages after Ubuntu Quantal (12.10). Actually, none of the alternatives of xscreensaver will be used by lxlock in the current fix, as xscreensaver is installed as a dependency of lxsession-logout and thus used by the script. Furthermore, I see no point of using code like if test x"`which xscreensaver-command 2>/dev/null`" != x""; then ... when you could use if which xscreensaver-command >/dev/null; then ... As for the lxlock script I uploaded earlier (https://launchpadlibrarian.net/154739229/lxlock), error handling in it fails since the exit statements exit only the innermost block, besides the script's exit code may be wrong. I attached the corrected script. ** Attachment added: "lxlock script that tries to lock by xscreensaver only. If it fails, it returns non-zero." https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/1205384/+attachment/3909627/+files/lxlock -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1205384 Title: Lock can be circumvented by switching to console To manage notifications about this bug go to: https://bugs.launchpad.net/lxde/+bug/1205384/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
