After talking with Chris the Vala code he is referring to being hard to review is the .c file changes, not the .vala changes. This is due to autotools (stupidly) distributing the .c files in the releases.
To be clear, the current code is not sometimes unresponsive, but severely unresponsive in all but the most trivial cases. This is due to the constant rewriting of image binary data (that may be huge) to a sqlite database (which is slow) on many unrelated document changes (e.g. moving the crop). Both the existing and new code deletes the autosave file on clean exit. Smaller changes were reviewed to the existing code but I judged them to be a higher risk than the new implementation. We could have the option to disable the autosave code for a simpler SRU, but this would be a feature regression. It is a useful feature since many SANE drivers can crash during a scan causing the user to loose all data. Note the new code is currently running in Ubuntu 14.04. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1245678 Title: MASTER: autosaves hang Simple Scan repeatedly on Ubuntu 13.10 To manage notifications about this bug go to: https://bugs.launchpad.net/simple-scan/+bug/1245678/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
