Understood. I've updated the wireframe to remove the speakers.

Some comments on the patch:

>         Gtk.Dialog.__init__(self, "Unknown audio device", None, 0)

Thanks to Jouni for the mockup, but Ubuntu for PC uses Title
Capitalization for window titles, e.g. "Unknown Audio Device" as in the
wireframe.

>         hp_btn = IconButton("audio-output-headphones", "Headphones", 
> "audio-headphones.svg", self)
>         icon_box.pack_start(hp_btn, False, True, 0)
>         mic_btn = IconButton("audio-input-microphone", "Microphone", 
> "audio-microphone.svg", self)
>         icon_box.pack_start(mic_btn, False, True, 0)
>         hs_btn = IconButton("audio-input-headset-mic", "Headset", 
> "audio-headset.svg", self)
>         icon_box.pack_start(hs_btn, False, True, 0)

I would prefer the Headphones and Headset buttons to be adjacent, as in
the wireframe, because that makes them easier to tell apart.

>        btn_box.pack_start(cancel_btn, False, False, 0)

Contra the mockup, Ubuntu standard dialog layout is for "Cancel" to go
second from the right, not in the left corner.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1239605

Title:
  Combo audio jack support ("what did you plug in?"-dialog)

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1239605/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to