Launchpad has imported 19 comments from the remote bug at
http://bugs.winehq.org/show_bug.cgi?id=35030.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2013-12-01T18:59:09+00:00 Le Gluon Du  Net wrote:

Created attachment 46692
crash log

Hello,

when I launch Steam install program, it crashes at the end of the
install, then continue with downloading the whole client. It is not an
important crash because it doesn't stop the install. I joined the log of
the crash.

Thank you for your help.

Config:
Ubuntu 13.10 
wine 1.7.7 32 bits
AMD radeon 7850 with Ubuntu Catalyst drivers 13.101 version
Processor Intel i5-3570 3,4 Ghz

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/0

------------------------------------------------------------------------
On 2013-12-01T19:29:09+00:00 Focht wrote:

Hello folks,

confirming.

It's not the installer crashing but the post-install part, the startup
of Steam client service.

--- snip ---
...
002f:Starting process L"C:\\Program Files\\Steam\\bin\\SteamService.exe" 
(entryproc=0x43d6fa) 
...
002f:Call advapi32.RegCreateKeyExA(80000002,0045f478 
"SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\Steam Client 
Service",00000000,00000000,00000000,00020006,00000000,0033fca0,00000000) 
ret=00407fe3
002f:Ret  advapi32.RegCreateKeyExA() retval=00000000 ret=00407fe3
002f:Call KERNEL32.GetModuleFileNameA(00000000,0033fa9c,00000200) ret=00408022
002f:Ret  KERNEL32.GetModuleFileNameA() retval=0000002b ret=00408022
002f:Call KERNEL32.lstrlenA(0033fa9c "C:\\Program 
Files\\Steam\\bin\\SteamService.exe") ret=0040802f
002f:Ret  KERNEL32.lstrlenA() retval=0000002b ret=0040802f
002f:Call advapi32.RegSetValueExA(0000003c,0045f424 
"EventMessageFile",00000000,00000002,0033fa9c,0000002c) ret=0040804d
002f:Ret  advapi32.RegSetValueExA() retval=00000000 ret=0040804d
002f:Call advapi32.RegSetValueExA(0000003c,0045f3ec 
"TypesSupported",00000000,00000004,0033fc9c,00000004) ret=00408097
002f:Ret  advapi32.RegSetValueExA() retval=00000000 ret=00408097
002f:Call advapi32.RegCloseKey(0000003c) ret=004080cf
002f:Ret  advapi32.RegCloseKey() retval=00000000 ret=004080cf
002f:Call advapi32.RegCreateKeyExA(80000002,0045b2f4 
"Software\\Valve\\Steam",00000000,00000000,00000000,000f003f,00000000,0033fdb0,00000000)
 ret=00408118
002f:Ret  advapi32.RegCreateKeyExA() retval=00000000 ret=00408118
002f:Call advapi32.OpenProcessToken(ffffffff,00000020,0033fc94) ret=0040a8d9
002f:Ret  advapi32.OpenProcessToken() retval=00000001 ret=0040a8d9
002f:Call advapi32.LookupPrivilegeValueA(00000000,004601d4,0033fc04) 
ret=0040a824
002f:Ret  advapi32.LookupPrivilegeValueA() retval=00000001 ret=0040a824
002f:Call 
advapi32.AdjustTokenPrivileges(00000044,00000000,0033fbf4,00000010,0033fbe4,00000000)
 ret=0040a86e
002f:trace:seh:raise_exception code=c0000005 flags=0 addr=0x7bc5bc1c 
ip=7bc5bc1c tid=002f
002f:trace:seh:raise_exception  info[0]=00000001
002f:trace:seh:raise_exception  info[1]=00000000
002f:trace:seh:raise_exception  eax=00000000 ebx=7bccf000 ecx=00000000 
edx=00000004 esi=0033fb80 edi=0033fb98
002f:trace:seh:raise_exception  ebp=0033fb18 esp=0033fa50 cs=0023 ds=002b 
es=002b fs=0063 gs=006b flags=00010206
002f:trace:seh:call_stack_handlers calling handler at 0x43e230 code=c0000005 
flags=0 
--- snip ---

MSDN: http://msdn.microsoft.com/en-
us/library/windows/desktop/aa375202%28v=vs.85%29.aspx

--- quote ---
OOL WINAPI AdjustTokenPrivileges(
  _In_       HANDLE TokenHandle,
  _In_       BOOL DisableAllPrivileges,
  _In_opt_   PTOKEN_PRIVILEGES NewState,
  _In_       DWORD BufferLength,
  _Out_opt_  PTOKEN_PRIVILEGES PreviousState,
  _Out_opt_  PDWORD ReturnLength
);

...
PreviousState [out, optional]

    A pointer to a buffer that the function fills with a
TOKEN_PRIVILEGES structure that contains the previous state of any
privileges that the function modifies. That is, if a privilege has been
modified by this function, the privilege and its previous state are
contained in the TOKEN_PRIVILEGES structure referenced by PreviousState.
If the PrivilegeCount member of TOKEN_PRIVILEGES is zero, then no
privileges have been changed by this function. This parameter can be
NULL.

    If you specify a buffer that is too small to receive the complete list of 
modified privileges, the function fails and does not adjust any privileges. In 
this case, the function sets the variable pointed to by the ReturnLength 
parameter to the number of bytes required to hold the complete list of modified 
privileges.
ReturnLength [out, optional]

    A pointer to a variable that receives the required size, in bytes, of the 
buffer pointed to by the PreviousState parameter. This parameter can be NULL if 
PreviousState is NULL.
--- quote ---

I checked the service binary code and "ReturnLength" is really hard-
coded to NULL while "PreviousState" is non-NULL (stack var).

Another case of MSDN not really telling the truth.

Source:
http://source.winehq.org/git/wine.git/blob/eef5e45ee6aae7029ec3ec0565fbbdc2ee29b59f:/dlls/ntdll/nt.c#l197

--- snip ---
197 NTSTATUS WINAPI NtAdjustPrivilegesToken(
...
204 {
...
210     SERVER_START_REQ( adjust_token_privileges )
211     {
...
224         if (PreviousState)
225         {
226             *ReturnLength = reply->len + FIELD_OFFSET( TOKEN_PRIVILEGES, 
Privileges );
227             PreviousState->PrivilegeCount = reply->len / 
sizeof(LUID_AND_ATTRIBUTES);
228         }
229     }
230     SERVER_END_REQ;
231
232     return ret;
233 }
--- snip ---

$ sha1sum SteamSetup.exe 
f2dd1ab2a96bd5b961bbc504458d5c53f242926c  SteamSetup.exe

$ du -sh SteamSetup.exe 
1.1M    SteamSetup.exe

$ wine --version
wine-1.7.7-230-g2507330

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/1

------------------------------------------------------------------------
On 2013-12-02T05:16:29+00:00 mr.larch wrote:

Ok, I'll do some tests for that.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/2

------------------------------------------------------------------------
On 2013-12-02T20:58:32+00:00 Focht wrote:

Hello folks,

this is fixed by commit
http://source.winehq.org/git/wine.git/commit/fd65b0a1c3f5f981cc110ca9e6a0edb6323e1296

Thanks Nikolay

--- snip ---
...
002f:Call advapi32.OpenProcessToken(ffffffff,00000020,0033fc94) ret=0040a8d9
002f:Ret  advapi32.OpenProcessToken() retval=00000001 ret=0040a8d9
002f:Call advapi32.LookupPrivilegeValueA(00000000,004601d4,0033fc04) 
ret=0040a824
002f:Ret  advapi32.LookupPrivilegeValueA() retval=00000001 ret=0040a824
002f:Call 
advapi32.AdjustTokenPrivileges(00000044,00000000,0033fbf4,00000010,0033fbe4,00000000)
 ret=0040a86e
002f:Ret  advapi32.AdjustTokenPrivileges() retval=00000000 ret=0040a86e
002f:Call advapi32.ConvertStringSidToSidA(0045fd6c,0033fc90) ret=0040a908
002f:Ret  advapi32.ConvertStringSidToSidA() retval=00000001 ret=0040a908
002f:Call advapi32.ConvertStringSidToSidA(004601e8,0033fc8c) ret=0040a916
002f:Ret  advapi32.ConvertStringSidToSidA() retval=00000001 ret=0040a916
002f:Call advapi32.SetEntriesInAclA(00000002,0033fc20,00000000,0033fc88) 
ret=0040a977
002f:Ret  advapi32.SetEntriesInAclA() retval=00000000 ret=0040a977
002f:Call advapi32.SetNamedSecurityInfoA(0045f590 
"MACHINE\\SOFTWARE\\Valve\\Steam",00000004,00000004,00000000,00000000,0012cc88,00000000)
 ret=0040a992
002f:Ret  advapi32.SetNamedSecurityInfoA() retval=00000000 ret=0040a992 
--- snip ---

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/3

------------------------------------------------------------------------
On 2013-12-03T22:38:54+00:00 Focht wrote:

*** Bug 35046 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/4

------------------------------------------------------------------------
On 2013-12-03T23:58:23+00:00 Bruno Gonçalves de Jesus wrote:

*** Bug 35047 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/5

------------------------------------------------------------------------
On 2013-12-04T10:36:00+00:00 Focht wrote:

*** Bug 35048 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/6

------------------------------------------------------------------------
On 2013-12-04T10:47:04+00:00 Focht wrote:

Hello folks,

refining summary in hope it will avoid more duplicates...

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/7

------------------------------------------------------------------------
On 2013-12-04T10:51:21+00:00 Focht wrote:

Hello folks,

commit fd65b0a1c3f5f981cc110ca9e6a0edb6323e1296 should also be
considered for cherry pick into stable branch if another 1.6.x happens
before 1.8

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/8

------------------------------------------------------------------------
On 2013-12-04T12:08:36+00:00 Focht wrote:

Well, considering this rather unusual API usage breaks all existing Wine 
versions I'm still undecided whether this can be attributed to laziness or foul 
play.
MSDN is quite clear about it ...

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/9

------------------------------------------------------------------------
On 2013-12-04T20:02:41+00:00 Babaei-wine wrote:

I built the latest version of Wine from the git repository with this
patch (wine-1.7.7-160-g58d96f7), and I'm still experiencing a failure of
the latest version of Steam to load. It was working well yesterday prior
to the latest Steam update.

I tested fresh installing Steam from the executable to a new WINEPREFIX
using wine-1.7.7-160-g58d96f7 and it still failed to load after the
Steam Guard step.

With both 1.7.7 and wine-1.7.7-160-g58d96f7, it successfully loads into offline 
mode and shows the following version information:
Steam Client Application
Built: Dec 3 2013, at 18:36:49
Steam API: v012
Steam package versions: 1386125885/1386125885

I've posted details including a trace here. I can generate more specific 
debugging information if it could help.
http://appdb.winehq.org/commentview.php?iAppId=1163&iVersionId=19444&iThreadId=88676

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/12

------------------------------------------------------------------------
On 2013-12-04T20:14:37+00:00 Focht wrote:

Hello babaei,

the log from your link shows you have not built from 'pure' Wine GIT source 
tree.
You have several unsupported patches applied.

If you can still reproduce with 'pure' Wine create a new bug.
The original breaking issue from Dec. 03 client update has been identified and 
fixed -> bug closed.
Please refrain from continuing this bug with unrelated issues.

FYI: Several people can run Steam Dec. 03 update without problems in
online mode.

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/13

------------------------------------------------------------------------
On 2013-12-04T21:06:27+00:00 Babaei-wine wrote:

I can assure you that I built my system directly from the git repository
without modifications and ran it directly from the source tree. I will
open a new bug, but I don't want it to be flagged as a duplicate of this
one.

I commented on this bug report because, in addition to not wanting to be
flagged as a duplicate, I was still experiencing "Steam Client update
from Dec. 3, 2013 breaks Wine" in spite of the fix.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/14

------------------------------------------------------------------------
On 2013-12-04T21:23:21+00:00 Focht wrote:

Hello babaei,

well then this pulseaudio thingy must be my imagination ...

--- quote ---
Even with the release version of 1.7.7, I never saw it fail with a page fault 
(like in the linked bug).
--- quote ---

Which basically means your system is somehow borked (broken WINEPREFIX, host 
issues).
Every Wine version that received the Dec. 03 Steam Client update should crash 
the same way in 'online' mode.

To reiterate: any further bug reports at this time, stating "steam is
broken" or "it still doesn't work" will definitely confuse _lots_ of
people that are currently seeking help in many forums/mailing
lists/entertainment websites.

Your problem seems to be an isolated issue.
There is #winehq IRC channel on freenode so join and we might work this one out 
without creating further confusion.

Regards

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/15

------------------------------------------------------------------------
On 2013-12-04T22:11:54+00:00 Babaei-wine wrote:

*** Bug 35050 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/16

------------------------------------------------------------------------
On 2013-12-05T07:54:45+00:00 Focht wrote:

*** Bug 35051 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/18

------------------------------------------------------------------------
On 2013-12-05T17:58:45+00:00 Xxblx-duke wrote:

Hello.

Tell me please. Bug already fixed. Fix patch commited into main branch.
So. Does that fix (patch) will be included into 1.7.8 release?

Thanks. 
Oleg.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/20

------------------------------------------------------------------------
On 2013-12-05T18:00:47+00:00 Bruno Gonçalves de Jesus wrote:

(In reply to comment #16)
> Tell me please. Bug already fixed. Fix patch commited into main branch.
> So. Does that fix (patch) will be included into 1.7.8 release?

Yes.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/21

------------------------------------------------------------------------
On 2013-12-05T18:18:30+00:00 Xxblx-duke wrote:

> Yes.

Thanks for your answer.

p.s. I interested because I don't do dev team "string freeze" before
release or no.

Thanks.
Oleg.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/1257734/comments/22


** Changed in: wine
       Status: Unknown => Fix Released

** Changed in: wine
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1257734

Title:
  Latest Steam update breaks wine

To manage notifications about this bug go to:
https://bugs.launchpad.net/wine/+bug/1257734/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to