I am not super impressed with code quality. Things like:
lib/md5.c:130:23: warning: argument to 'sizeof' in 'memset' call is the same
expression as the destination; did you mean to dereference it?
[-Wsizeof-pointer-memaccess]
memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */
And plenty of:
lib/pdu.c:239:2: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
ttt = ntohl(*(uint32_t *)&in->hdr[20]);
As for tests, is there a way we could run them as a dep8 test, and run a
local server during it?
** Changed in: libiscsi (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1271653
Title:
[MIR] libiscsi
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libiscsi/+bug/1271653/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
