== Must fix ==

1) The package forces itself into zh_CN.UTF-8 locale, which is not
guaranteed to exist on the user system. Therefore the package should
depend on "language-pack-zh-hans" such that such a locale is available
at runtime.

Traceback:
 Traceback (most recent call last):
   File "ubuntu-kylin-software-center.py", line 1080, in <module>
     main()
   File "ubuntu-kylin-software-center.py", line 1072, in main
     mw = SoftwareCenter()
   File "ubuntu-kylin-software-center.py", line 151, in __init__
     self.appmgr.init_models()
   File "/usr/share/ubuntu-kylin-software-center/models/appmanager.py", line 
156, in init_models
     self._init_models()
   File "/usr/share/ubuntu-kylin-software-center/models/appmanager.py", line 
142, in _init_models
     self.open_cache()
   File "/usr/share/ubuntu-kylin-software-center/models/appmanager.py", line 
135, in open_cache
     locale.setlocale(locale.LC_ALL, "zh_CN.UTF-8")
   File "/usr/lib/python2.7/locale.py", line 579, in setlocale
     return _setlocale(category, locale)
 Error: unsupported locale setting

2) Why is this package split into arch:any and arch:all ? the arch:any
package has no architecture dependent files, therefore this should just
be a single binary package, arch:all, "ubuntu-kylin-software-center"

3) Why "3.0 (quilt)" format? There clearly is no pristine tarballs which
are released normally (and the watch file points to autogenerated
tarballs from a recipe builds, by the looks of things). So i think the
package should just be declared "3.0 (native)" and build if from the
branch each time.

4) Package should depend on ubuntukylin-keyring

I'll submit a merge proposal for above.

== Can fix later  / other comments ==

2) Can be fixed later -> there are a lot of messages from pyflakes
$ pyflakes . | wc -l
112
Typically we expect python software to be pyflakes & pep8 clean

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1293299

Title:
  [FFe]upload ubuntu-kylin-software-center into archive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntukylin/+bug/1293299/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to