Thanks for writing a patch for this! A quick note:

xfdesktop_move_all_cached_icons_to_desktop(XfdesktopIconView *
{
#ifdef ENABLE_FILE_ICONS
    GList *l, *leftovers = NULL;
    XfdesktopFileIconManager *fmanager = NULL;

    TRACE("entering");

    if(XFDESKTOP_IS_FILE_ICON_MANAGER(icon_view->priv->manager))
        fmanager = XFDESKTOP_FILE_ICON_MANAGER(icon_view->priv-

    if(fmanager == NULL)
        return;

+    xfdesktop_file_icon_save(fmanager);

If we add the save function there you won't need the if check.

I don't forsee any issues with your patch, but I won't have time
to fully test this patch until the weekend, I just wanted to provide
some quick feedback. If you're ok with my proposed change, either
you or I can turn the diff into a git formatted patch for inclusion
into xfdesktop.
http://docs.xfce.org/contribute/dev/git/start provides info and
links if you've never worked with git before and want to.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1307251

Title:
  xfdesktop doesn't save the arrangement of desktop icons after a
  resolution change

To manage notifications about this bug go to:
https://bugs.launchpad.net/xfdesktop/+bug/1307251/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to