Hi Chris, In general this looks good, but I have a few questions.
First, I notice this changeset drops the patch system in favor of using git. Since upstream uses git, and since we currently use bzr only in situations where launchpad can track the upstream vcs (i.e. svn, cvs), I'm not certain this is the right approach. Can you explain why you chose to go this route? Second, I notice there are a number of Makefile.in and auto* files in the ubuntu diff, presumably because autogen.sh was run after creating the git snapshot. In general it seems more standard to include the autogen.sh'd files in the snapshot, rather than in the ubuntu diff. This keeps the ubuntu change simpler. Would you mind making these changes? Then I think this would be good for upload. -- FTBFS https://bugs.launchpad.net/bugs/126255 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
