** Description changed:

  After upgrading from 12.04 to 14.04, I noticed that gogoc no longer
  started. I tracked it down to a logical error in the bash script to
  build the tunnel.
  
  The following line appears 3 times in /usr/share/gogoc/template/linux.sh
  (lines 167, 279 and 312):
  
  echo "$subif" | while read sub int ; do
  
- It should read:
- 
- echo "$subif" || while read sub int ; do
- 
- (Note that "|" becomes "||")
+ It needs to first test that $subif is empty:
  
  When the subinterfaces file (/etc/gogoc/interfaces.conf) is empty or
  missing, the subif variable has an empty value. It appears that the
  intention of the aforementioned line in linux.sh is to test for an empty
  value, and only process it if it's populated. It doesn't seem to work
  this way.
  
  What is happening, is that the radvd config file is populated with a
  second interface containing uninitialized nonsense, and radvd in turn
  fails to parse the config file. Radvd will then return an error status
  and gogoc will react by tearing down the tunnel.

** Patch removed: "gogoc-bug.patch"
   
https://bugs.launchpad.net/ubuntu/+source/gogoc/+bug/1312649/+attachment/4096417/+files/gogoc-bug.patch

** Patch added: "gogoc-bug.patch"
   
https://bugs.launchpad.net/ubuntu/+source/gogoc/+bug/1312649/+attachment/4096432/+files/gogoc-bug.patch

** Description changed:

  After upgrading from 12.04 to 14.04, I noticed that gogoc no longer
  started. I tracked it down to a logical error in the bash script to
  build the tunnel.
  
  The following line appears 3 times in /usr/share/gogoc/template/linux.sh
  (lines 167, 279 and 312):
  
  echo "$subif" | while read sub int ; do
  
  It needs to first test that $subif is empty:
  
  When the subinterfaces file (/etc/gogoc/interfaces.conf) is empty or
- missing, the subif variable has an empty value. It appears that the
- intention of the aforementioned line in linux.sh is to test for an empty
- value, and only process it if it's populated. It doesn't seem to work
- this way.
+ missing, the subif variable has an empty value.
  
  What is happening, is that the radvd config file is populated with a
  second interface containing uninitialized nonsense, and radvd in turn
  fails to parse the config file. Radvd will then return an error status
  and gogoc will react by tearing down the tunnel.

** Description changed:

  After upgrading from 12.04 to 14.04, I noticed that gogoc no longer
  started. I tracked it down to a logical error in the bash script to
  build the tunnel.
  
  The following line appears 3 times in /usr/share/gogoc/template/linux.sh
  (lines 167, 279 and 312):
  
  echo "$subif" | while read sub int ; do
  
- It needs to first test that $subif is empty:
+ It needs to first test that $subif is empty.
  
  When the subinterfaces file (/etc/gogoc/interfaces.conf) is empty or
  missing, the subif variable has an empty value.
  
  What is happening, is that the radvd config file is populated with a
  second interface containing uninitialized nonsense, and radvd in turn
  fails to parse the config file. Radvd will then return an error status
  and gogoc will react by tearing down the tunnel.

** Description changed:

  After upgrading from 12.04 to 14.04, I noticed that gogoc no longer
  started. I tracked it down to a logical error in the bash script to
  build the tunnel.
  
  The following line appears 3 times in /usr/share/gogoc/template/linux.sh
  (lines 167, 279 and 312):
  
  echo "$subif" | while read sub int ; do
  
- It needs to first test that $subif is empty.
+ It needs to first test that $subif is not empty.
  
  When the subinterfaces file (/etc/gogoc/interfaces.conf) is empty or
  missing, the subif variable has an empty value.
  
  What is happening, is that the radvd config file is populated with a
  second interface containing uninitialized nonsense, and radvd in turn
  fails to parse the config file. Radvd will then return an error status
  and gogoc will react by tearing down the tunnel.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312649

Title:
  linux.sh processes empty/missing subinterface file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gogoc/+bug/1312649/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to