MIR review:
* Does it FTBFS currently? build fine, with packages only in main
* Does it have a test suite? HACKING.md details how to run the testsuite, but 
this is not enabled in the build
* Does it have a team bug subscriber? no, it needs one
* Is the code translatable (if user visible)? N/A
* Does Ubuntu carry a delta? no
* Does it have a watch file? yes
* Is its update history slow or sporadic? Debian update history is slow
* Is the current release packaged? No. 1.4.0 is available but 1.3.4 is in the 
archive. 1.3.4 is the latest 1.3 version
* Will entering main make it harder for the people currently keeping it up to 
date? no-- syncs with Debian are expected
* Lintian warnings. Two issues:
E: ninja-build: copyright-should-refer-to-common-license-file-for-apache-2
E: ninja-build-doc: copyright-should-refer-to-common-license-file-for-apache-2
* Is debian/rules a mess? uses dh7 with overrides
* Errors/warnings during the build: yes, but only with documentation generation
* Incautious use of malloc/sprintf: spot-checking seems fine
* Uses of sudo, gksu, pkexec, or LD_LIBRARY_PATH: no
* Important bugs (crashers, etc) in Debian or Ubuntu: no Ubuntu bugs, one bug 
in Debian for sparc build

No need for security review.

Conditional ACK provided:
* testsuite is enabled
* a team bug subscriber is assigned
* bug filed in Debian on lintian issue (fix not required for promotion)
* bug filed in Debian on documentation generation errors during the build (fix 
not required for promotion)


** Changed in: ninja-build (Ubuntu)
       Status: New => In Progress

** Changed in: ninja-build (Ubuntu)
     Assignee: Jamie Strandboge (jdstrand) => Chris Coulson (chrisccoulson)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1315313

Title:
  [MIR] ninja-build

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ninja-build/+bug/1315313/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to