Thanks Sebastien,
I have reduced the change down to just the patch that fixes the bug preventing
the editing of notes. I hope it is now suitable and that the SRU can now be
sponsored. I have pushed the update to launchpad:
lp:~retail-0/ubuntu/trusty/gramps/bug-1320596
An updated debdiff is also attached.
The following is an updated text justifying the SRU:
Recommend an SRU (Stable Release Update)
[Impact]
This bug renders Gramps unusable for Genealogists because it is
critical that you can save and edit notes whilst researching family
trees. This is a very important function within Gramps.
The patch is very small, and is taken directly from the development release
(Utopic) which synced it from Debian:
diff --git a/gramps/gui/widgets/styledtexteditor.py
b/gramps/gui/widgets/styledtexteditor.py
18 index a1c92db..d303404 100644
19 --- a/gramps/gui/widgets/styledtexteditor.py
20 +++ b/gramps/gui/widgets/styledtexteditor.py
21 @@ -179,7 +179,8 @@ class StyledTextEditor(Gtk.TextView):
22 self.textbuffer = UndoableStyledBuffer()
23 self.textbuffer.connect('style-changed', self._on_buffer_style_changed)
24 self.textbuffer.connect('changed', self._on_buffer_changed)
25 - GObject.GObject.__init__(self, buffer=self.textbuffer)
26 + GObject.GObject.__init__(self)
27 + self.set_buffer(self.textbuffer)
28
29 st_cont = self.get_style_context()
30 col = st_cont.lookup_color('link_color')
[Test Case]
Test Case 1 - Create a new note:
1. Create a new Empty Family Tree.
2. Goto "Notes" view using the left pane.
3. Click on "+" to add a new note.
4. Type something (e.g. "blabla") into the Text Field.
5. Click "OK".
> Instead of the note being saved, you get an error message "Cannot Save Note"
> and can only cancel the operation.
Test Case 2 - Edit an existing note:
1. Download the example file from:
http://sourceforge.net/p/gramps/source/ci/maintenance/gramps40/~/tree/example/gramps/data.gramps
2. From the "Family Tree" Menu, import the downloaded file.
2. Goto "Notes" view using the left pane.
3. Double-Click on one of the notes
> Instead of seeing the text you saw in the preview, the note text field is
> empty. Typing in text is futile, when you click "OK" there is no error
> message, but what you added to the note is not saved and is not present in
> the Note View preview, only the old text.
[Regression Potential]
* There little risk of regression because the patch is minor.
* The fix has been tested upstream, in Debian, and in the Ubuntu
Development Release (Utopic).
* In the worst case, user data could be erased if something is wrong in
this area of the code that has not been detected so far. But the users
would probably prefer to have this fix anyway, as they cannot really use
Gramps as intended at the moment.
[Other Info]
* Nothing further to add.
** Patch added: "Updated deb diff for SRU"
https://bugs.launchpad.net/ubuntu/+source/gramps/+bug/1320596/+attachment/4124370/+files/gramps-1320596.debdiff
** Changed in: gramps (Ubuntu Trusty)
Assignee: Ross Gammon (retail-0) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1320596
Title:
Gramps unable to create or edit notes
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gramps/+bug/1320596/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs