Public bug reported:

dkms package builds fine with kernel 3.13 but not with kernel 3.16 any
more.

Tested with 
a) Ubuntu 14.10 Alpha and
b) Ubuntu 14.04 with PPA package linux-meta-lts-utopic

Other Linux users also report this issue with newer kernels (as of 3.15 I 
guess):
https://code.google.com/p/r8168/issues/detail?id=19


Please check attached make.log for details.

I was able to  resolve the issues with a quick-n-dirty patch that I have
also pasted into this bug report. This patch might not be the best
solution and may not be downward compatible to kernel 3.13.

--- r8168-8.038.00.orig/src/r8168_n.c
+++ r8168-8.038.00/src/r8168_n.c
@@ -17542,7 +17542,8 @@ rtl8168_init_one(struct pci_dev *pdev,
 
     RTL_NET_DEVICE_OPS(rtl8168_netdev_ops);
 
-    SET_ETHTOOL_OPS(dev, &rtl8168_ethtool_ops);
+    //SET_ETHTOOL_OPS(dev, &rtl8168_ethtool_ops);
+    dev->ethtool_ops = &rtl8168_ethtool_ops;
 
     dev->watchdog_timeo = RTL8168_TX_TIMEOUT;
     dev->irq = pdev->irq;
@@ -19119,7 +19120,7 @@ static void rtl8168_schedule_work(struct
 {
     struct rtl8168_private *tp = netdev_priv(dev);
 
-    PREPARE_DELAYED_WORK(&tp->task, task);
+    INIT_DELAYED_WORK(&tp->task, task);
     schedule_delayed_work(&tp->task, 4);
 }
 #endif

Cheers,
Henning

** Affects: r8168-dkms (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "dkms make log with two error messages"
   https://bugs.launchpad.net/bugs/1345548/+attachment/4157861/+files/make.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1345548

Title:
  r8168-8.038.00 doesn't build on kernel 3.16.x (PREPARE_DELAYED_WORK,
  SET_ETHTOOL_OPS)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/r8168-dkms/+bug/1345548/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to