Fix uploaded for Utopic (0.97-3ubuntu1). ** Bug watch added: Debian Bug tracker #756300 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756300
** Also affects: terminator (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756300 Importance: Unknown Status: Unknown ** Changed in: terminator (Ubuntu) Assignee: (unassigned) => Chris J Arges (arges) ** Changed in: terminator (Ubuntu Trusty) Importance: Undecided => Medium ** Changed in: terminator (Ubuntu) Status: New => In Progress ** Changed in: terminator (Ubuntu) Importance: Undecided => Medium ** Description changed: + SRU Justification: + [Impact] + Users of terminator cannot close tabs with multiple split terminals. + + [Test Case] + Start terminator. Create new tab, split new tab into multiple terminals. Try to close newly created tab. + We expect this to close. + + [Regression Potential] + Patch is a small bugfix, and has been already committed upstream. + + -- + Terminator 0.97 If there are multiple terminals in a tab, the user is prompted for confirmation. Then, the program fails to close the tab and does so silently. The confusion is about the return value of construct_confirm_close() Fix: $ bzr diff === modified file 'terminatorlib/notebook.py' --- terminatorlib/notebook.py 2013-10-25 14:55:26 +0000 +++ terminatorlib/notebook.py 2013-11-22 11:41:31 +0000 @@ -318,9 +318,7 @@ - return - elif maker.isinstance(child, 'Container'): - dbg('Notebook::closetab: child is a Container') + return + elif maker.isinstance(child, 'Container'): + dbg('Notebook::closetab: child is a Container') - dialog = self.construct_confirm_close(self.window, _('tab')) - result = dialog.run() - dialog.destroy() + result = self.construct_confirm_close(self.window, _('tab')) - - if result == gtk.RESPONSE_ACCEPT: - containers = None + + if result == gtk.RESPONSE_ACCEPT: + containers = None -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1253995 Title: Tab with multiple terminals not closed To manage notifications about this bug go to: https://bugs.launchpad.net/terminator/+bug/1253995/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
