-> brise * BLOCKER: kyotocabinet-utils build-deps is in universe. Please add that one to the MIR if it matches the MIR criterias or drop those. * BLOCKER: COPYING is GPL3. Some files are LGPL-2+, GPL-2+ and those requires the license to be shipped in the upstream source. Please make upstream to ship those in their tarball. * MINOR/NEED INFO: any idea why the source has a priority extra?
------- -> fcitx: * BLOCKER: presagege is missing as a build-dep, do you mind either not building with it (optional dep) or add it and check it matches the MIR criterias? * BLOCKER: there are some LGPL files and no COPYING.LGPL file, please ship it in the upstream tarball. * NEED INFO/FIXING: fcitx-libs-gclient (and a lot of other binary packages): package-name-doesnt-match-sonames. Do you know why we don't follow upstream soname? They are at 0, so package name should be fcitx-libs-gclient0 as it's a public library. Otherwise, it should be in a private path. * NEED FIXING: I noted the remark on fcitx-libs in debian/README.source, and even if I'm not a fan of the current approach of the 3 libraries in the same package, I think we can live with it. However, we need to have a soname in the end, so that the binary package name can be bumped for any soname breaking in one of the 3 libraries (as some rdepends are not frmothe same source pacakage, like kde-config-fcitx or youker-assistant). * NEED FIXING: even if it's wrap under a sh call, better to be coherent and get the script executable: W: fcitx-bin: script-not-executable usr/share/fcitx/data/env_setup.sh * NEED FIXING: debian/copyright: - fcitx-4.2.8.4/src/frontend/qt/keyserver_x11.h: missing copyright to 2004 Jaroslaw Staniek <[email protected]> - fcitx-4.2.8.4/src/frontend/xim/lib/XimProto.h: missing the copyright (1992, 1993, 1994 by FUJITSU LIMITED) - src/ui/kimpanel/kimpanel.c. You set "Copyright: 2008-2010, Zealot.Hoi", but it misses "2010~2012 by CSSlayer *" (files: * doesn't cover it as it's overriden) - Copyright: 2003-2009, Troy D. Hanson http://uthash.sourceforge.net => it's actually 2003-2010 - Files: src/lib/fcitx-utils/qsort_r.c. Please mention the short name of the license "MIT/X11 (BSD like)" - fcitx-4.2.8.4/src/lib/fcitx-qt/fcitxqtkeysequencewidget.h and fcitx-4.2.8.4/src/lib/fcitx-qt/fcitxqtkeysequencewidget_p.h: GPL (v2 or later) LGPL (v2 or later) Missing: 2007 Andreas Hartmetz <[email protected]> / 2001, 2002 Ellis Whitehead <[email protected]> - fcitx-4.2.8.4/src/module/lua/luawrap.c/h, fcitx-4.2.8.4/src/module/lua/luamod.c/h:: GPL (v2 or later). [Copyright: 2012~2012 by xubin *] (needs mention) * MINOR: debian/patches/ubuntu-disable-fcitx-xkb.patch: do you mind using DEP3 for annotating the patch? (http://dep.debian.net/deps/dep3/) * MINOR: I think you should add a head to debian/control (after you cp the .in to the control file) to tell to not edit that file as debian/rules, through gencontrol.mk is going to edit and sed it. * NEEDS INFO: I see that we are running the unit tests at build time. Is there any integration tests that we can run, installing the various modules? (like -anthy, -chewing… and so on…) ----- -> fcitx-anthy: * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control * NEED FIXING: debian/copyright: doesn't contain any other copyright holder. Please fix it. For instance: src/factory.h: GPL (v2 or later) [Copyright: 2004 Hiroyuki Ikezoe / 2004 Takuro Ashie / 2012 CSSlayer / 2004 James Su <[email protected]>] src/imengine.cpp: GPL (v2 or later) [Copyright: 2004 - 2005 Hiroyuki Ikezoe <[email protected]> / 2012 CSSlayer / 2004 - 2005 Takuro Ashie <[email protected]> / 2004 James Su <[email protected]>] ------ -> ficitx-cloudpinyin: * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control * MINOR: debian/copyright: Copyright should be 2011-2012, not only 2011 * NITPICK: typo in debian/control: "to retrive result candidates" -> retrieve ------ -> fcitx-configtool * BLOCKER: debian/copyright is not well-formated: line 5: missing Files: line. The License text should be in a separate stanza as well. * NITPICK: debian/copyright Depends: line for fcitx-config-gtk is too long, please wrap it. ------ -> fcitx-googlepinyin * BLOCKER: same issue in debian/copyright * BLOCKER: build-dep on libgooglepinyin0-dev which is in universe. Please drop that plugin from the MIR or add the dependency after checking it's suiting the MIR requirements. * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control ------ -> fcitx-hangul * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control * NEEDS INFO: fcitx-hangul: hardening-no-stackprotector usr/lib/x86_64-linux-gnu/fcitx/fcitx-hangul.so. Any way we can fix this? Not having stackprotector leads the potentially code that can be attacked. * MINOR: debian/copyright: Copyright: 2012 CSSlayer <[email protected]> -> should be 2010-2012 ------ -> fcitx-m17n * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control * MINOR: debian/copyright: missing Copyright: 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald in im/keysymname.c ------ -> fcitx-qimpanel: * BLOCKER: there is no COPYING for GPL2 and GPL3. Both are needed to be shipped upstream. * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control * NEEDS INFO: I guess the autostart binary shouldn't be in usr/bin, but more in an exec path like libexec for instance. ------ -> fcitx-qimpanel-configtool: * BLOCKER: there is no COPYING for GPL2 and GPL3. Both are needed to be shipped upstream. There is only an empty LICENSE file. ------ -> fcitx-qt5 * BLOCKER: there is no COPYING for GPL2 nor LGPL2. Both are needed to be shipped upstream. * NEEDS FIXING: fcitx-libs-qt5: package-name-doesnt-match-sonames libfcitx-qt5-0. Please rename the binary package + add an override, there is only one shared lib and it's better to follow debian packaging convention for Qt libs. * NEEDS FIXING: debian/copyright: missing src/keyserver_x11.h: LGPL (v2 or later) [Copyright: 2001 Ellis Whitehead <[email protected]> / 2004 Jaroslaw Staniek <[email protected]>] * MINOR: it would be nice to have a .symbol file. ------ -> fcitx-rime: * BLOCKER: COPYING is GPL2, so we can assume the only file is src/fcitx-rime.c is under that license. debian/copyright mention GPL3+. Needs to be fixed in accordance. * BLOCKER: build-deps on librime which is in universe. Please add that one to the MIR if it matches the MIR criterias or drop that one. * BLOCKER: this package doesn't build on armhf which is one of our supported arch. It needs to be buildable on that arch (librime-data can't be installed) * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control * MINOR: The source in debian/copyright is fcitx one, not fcitx-rime ------ -> fcitx-sunpinyin: * BLOCKER: COPYING is GPL2 as the files from the project. debian/copyright mention GPL3+. Needs to be fixed in accordance. * BLOCKER: debian/copyright is not well-formated (same issue than in fcitx-configtool) * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control ------ -> fcitx-table-extra: * BLOCKER: tables/scj6.txt is GPL3, there is no COPYING file mentionning GPL3. You need upstream to ship it. * NEEDS FIXING: W: fcitx-table-cantonese: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/64x64/apps/fcitx-cantonese.png 48x48 W: fcitx-table-stroke5: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/64x64/apps/fcitx-stroke5.png 48x48 W: fcitx-table-zhengma: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/48x48/apps/fcitx-zhengma.png 64x64 * NEEDS INFO: debian/rules: override_dh_install: find . -name *.mo -delete why stripping the generated .mo file? They aren't shown anyway in any UI? ------ -> fcitx-table-other: * NEEDS INFO: debian/rules: override_dh_install: find . -name *.mo -delete why stripping the generated .mo file? They aren't shown anyway in any UI? ------ -> librime: * BLOCKER: libkyotocabinet-dev, libmarisa-dev and libyaml-cpp-dev build-deps are in universe. Please add that one to the MIR if it matches the MIR criterias or drop those. Note that libboost-signals-dev is in universe, but the source is in main, so we can promote it as the same time. * MINOR: would be nice to multi-arch the library. * MINOR: it would be nice to have a .symbol file (not sure why there is an override no-symbols-control-file) * MINOR: debian/copyright: Files: thirdparty/src/glog/* thirdparty/src/gtest/* Copyright: 2008, Google Inc. It should be 1999-2008 * MINOR/NEED INFO: any idea why the source has a priority extra? Please fix those/provides feedback on them and reping me once done. :) Note when promoting (if promoting librime) -> push libboost-signals-dev binary to main. ** Changed in: brise (Ubuntu) Status: New => Incomplete ** Changed in: fcitx (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-anthy (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-cloudpinyin (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-chewing (Ubuntu) Status: New => Fix Committed ** Changed in: fcitx-configtool (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-googlepinyin (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-hangul (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-m17n (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-qimpanel (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-qimpanel-configtool (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-qt5 (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-rime (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-sunpinyin (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-table-extra (Ubuntu) Status: New => Incomplete ** Changed in: fcitx-table-other (Ubuntu) Status: New => Incomplete ** Changed in: librime (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1356222 Title: [MIR] fcitx and related packages To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/brise/+bug/1356222/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
