Dann, I think it's more consistent to use the same rule structure as in ProLiant-m800-power-button.patch, i. e. "cat" and RESULT=. If you want to use grep, then please use "grep -q". I'm also ok with using grep in both rules, but we should just use one form.
Also, please merge this into the previous patch, and rename to ProLiant- power-button.patch; there might be more platforms, and we don't want dozens of these very closely related micro-patches. That will make patch review/changing, easier and reduce patch interdependencies. Otherwise this LGTM. Please don't upload the utopic one, I'll apply your final patch for trusty to the Debian/Ubuntu packaging git and then upload with some other changes soon. (I suppose the pressing part is trusty, not utopic?) Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1354306 Title: gpio shutdown trigger for ProLiant m400 cartridges To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1354306/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
