Launchpad has imported 6 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=7959.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-09-06T06:41:57+00:00 Ikonta wrote:

XFce Terminal suggests to copy url into memory buffer.

If source string looks like:
<a>http://ya.ru/</a>
operation is correct.

But if url doesn't contain tailing '/', terminal copies +1 symbol (doesn't 
check close tag?).
I.e. if the source string is:
<a>http://ya.ru</a>
In the memory buffer is copied (and pasted) incorrect url string:
'http://ya.ru<'

P.S. If trying to copy url from href argument of 'a' tag both cases
(i.e. present and missed tailing '/') works correctly.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-terminal/+bug/408315/comments/4

------------------------------------------------------------------------
On 2013-07-22T17:47:43+00:00 Jshipley-2 wrote:

URL recognition seems to have a few problems (and seems to work mostly
the same as gnome-terminal which isn't surprising since it looks like
both applications use nearly identical regexes to match).

The opening character of a pair ('(', '<', '{', and '[') get added to
the URL but terminate the URL. The exception to this is when they
directly follow a '/' (not necessarily tailing,
"http://www.foo.com/(whatisthis/more" would be recognized as
"http://www.foo.com/";). This causes problems for wikipedia style links
with '(' and ')' in them
(https://bugzilla.xfce.org/show_bug.cgi?id=9800). The closing character
of the pair does not get recognized as part of the URL.

Actually, it looks like any single character following a slash will be
ignored.

http://www.foo.com/a matches http://www.foo.com/
http://www.foo.com/ab matches http://www.foo.com/ab

If the current regex can't be easily fixed, it may be worth looking into
http://daringfireball.net/2010/07/improved_regex_for_matching_urls as a
replacement.

I'm going to spend some time with this, and see if I can come up with a
good patch.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-terminal/+bug/408315/comments/5

------------------------------------------------------------------------
On 2013-07-23T07:30:00+00:00 Ncopa wrote:

Created attachment 5099
Patch from dev mailing list

this is the patch Jeff sent to mailing list.

It also fixes bug #9800 but I post it only here.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-terminal/+bug/408315/comments/6

------------------------------------------------------------------------
On 2013-07-23T19:28:10+00:00 Jshipley-2 wrote:

Created attachment 5100
patch without duplicate USERS define

I recreated the above patch as it duplicated the "#define USERS" line
instead of just changing it.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-terminal/+bug/408315/comments/7

------------------------------------------------------------------------
On 2013-07-25T11:00:30+00:00 8-nick wrote:

*** Bug 9800 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-terminal/+bug/408315/comments/8

------------------------------------------------------------------------
On 2013-07-25T11:04:26+00:00 8-nick wrote:

Pushed in 2e1c325. Thanks.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-terminal/+bug/408315/comments/9


** Changed in: xfce4-terminal
       Status: Unknown => Fix Released

** Changed in: xfce4-terminal
   Importance: Unknown => Medium

** Bug watch added: Xfce Bugzilla #9800
   https://bugzilla.xfce.org/show_bug.cgi?id=9800

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/408315

Title:
  Trailing closing bracket in URL not considered part of the URL

To manage notifications about this bug go to:
https://bugs.launchpad.net/xfce4-terminal/+bug/408315/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to