Launchpad has imported 6 comments from the remote bug at https://bugzilla.xfce.org/show_bug.cgi?id=11113.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2014-08-27T19:46:01+00:00 Yves-Alexis Perez wrote: Hi, it seems that the logic for handling logind inhibitions is completely backward. The keys are named logind-handle-<foo> (and default to TRUE) which seems to indicate that *logind* does the job, not xfce4-power-manager. But when actually adding inhibitors, the code (http://git.xfce.org/xfce/xfce4-power-manager/tree/src/xfpm- manager.c#n502) actually does the opposite: if the key is true, then xfpm considers that it has to do the job, and adds a dbus inhibitor. That's completely confusing. Either the key names have to be changed, or the logic. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1349056/comments/8 ------------------------------------------------------------------------ On 2014-08-27T20:08:48+00:00 Yves-Alexis Perez wrote: Created attachment 5614 invert the logind xfconf keys logic This patch should fix the issue, I guess. It sets the default keys to FALSE, and then only add the inhibits if the current keys are FALSE. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1349056/comments/9 ------------------------------------------------------------------------ On 2014-08-27T20:25:55+00:00 Yves-Alexis Perez wrote: Created attachment 5615 invert the logind xfconf keys logic New version which also updates the variable names for more clarity. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1349056/comments/10 ------------------------------------------------------------------------ On 2014-09-01T05:23:44+00:00 Yves-Alexis Perez wrote: Ping? Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1349056/comments/11 ------------------------------------------------------------------------ On 2014-09-01T17:27:12+00:00 Eric Koegel wrote: Simon and Sean were working on this so I'll let them take the lead :) Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1349056/comments/12 ------------------------------------------------------------------------ On 2014-09-03T10:58:27+00:00 Sean Davis wrote: (In reply to Yves-Alexis Perez from comment #2) > Created attachment 5615 [details] > invert the logind xfconf keys logic > > New version which also updates the variable names for more clarity. This patch seems to make sense of it all. Please apply it going forward. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1349056/comments/13 ** Changed in: xfce4-power-manager Status: Unknown => Confirmed ** Changed in: xfce4-power-manager Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1349056 Title: xfce4-power-manager doesn't suspend on lid closed (regression) To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-power-manager/+bug/1349056/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
