@xtrusia: Did you ever even test that debdiff vs. 4.2? I doesnt even seem to compile: - For one there seems to be an obvious typo in using both rMark.getMarkedRanges() and rMark.GetMarkedRanges() in the same patch - Curiously this typo isnt even there in the upstream commit 91502a72c12c559442e8bf77c27a516b49c2a68d from which it was derived - then the patch uses sc::ColRowSpan which does not seem to be available on LibreOffice 4.2.x yet
Here is an example build log failure: https://launchpadlibrarian.net/187606247/buildlog_ubuntu-trusty-amd64.libreoffice_1%3A4.2.7~rc2-0ubuntu1_FAILEDTOBUILD.txt.gz Im not too happy to have wasted some time to rebase the patch from 4.2.6 on 4.2.7, now realizing this likely never build on 4.2.6 in the first place. In the future, please in general consider using the upstream backport branches as per: https://wiki.documentfoundation.org/Development/Branches#libreoffice-X-Y on https://gerrit.libreoffice.org. For one, this gives you the support of upstream CI and buildbots, but more importantly also the support of upstream reviewers. Sadly, its now too late for this to succeed with that as 4.2.7.2 has been tagged and is at the end of the upstream support for this series. For now, I will leave the patch in packaging (so that the rebase work isnt lost), but disable it. If you want this patch to still make the next trusty SRU, the patch needs to be in a good form against 4.2.7 and be thoroughly tested before the end of October 2014. That means you need to do a build and at least run the autopkgtests against it and at least do some basic manual testing in the patched functionality. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1342175 Title: [upstream] Poor performance with find & replace with empty value on large data set To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1342175/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
