Launchpad has imported 23 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=9905.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2013-03-10T22:29:01+00:00 thesame wrote:

Add the ability to undecorate maximized windows to save vertical space
on screen.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/5

------------------------------------------------------------------------
On 2013-03-10T22:29:20+00:00 thesame wrote:

Implemented here https://bitbucket.org/thesame/xfwm4-titleless

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/6

------------------------------------------------------------------------
On 2013-03-11T20:09:05+00:00 Olivier Fourdan wrote:

(In reply to comment #1)
> Implemented here https://bitbucket.org/thesame/xfwm4-titleless

Please attach patches here if you want this upstream (can't really teach
changes from another git repo,not convenient...)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/7

------------------------------------------------------------------------
On 2013-03-11T20:19:46+00:00 Olivier Fourdan wrote:

Note, title-less maximization is already covered by EWMH, so this needs
to be implemented via the standard, making it an unconditional option in
not the right way to add this feature.

1. add support for EWMH standard for borderless maximization
2. make sure it's not just the title, but border as we'll (ie there is already 
an option to show or hide borders on maximization, make sure this work in any 
case)
3. once the feature supports the standard, we can add a user option to set the 
default behaviour, for apps that don't specify their desired maximization mode 
via the standard.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/8

------------------------------------------------------------------------
On 2013-03-12T01:11:25+00:00 thesame wrote:

Created attachment 4959
Adds ability to hide titles of maximized windows

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/9

------------------------------------------------------------------------
On 2013-03-12T01:11:50+00:00 thesame wrote:

(In reply to comment #3)
> Note, title-less maximization is already covered by EWMH, so this needs to
> be implemented via the standard, making it an unconditional option in not
> the right way to add this feature.

I couldn't find appropriate EWMH atom to show/hide titles of maximized
windows. My solution isn't unconditional, it adds new checkbox
(initially unchecked) to WM tweaks.

> 1. add support for EWMH standard for borderless maximization
> 2. make sure it's not just the title, but border as we'll (ie there is
> already an option to show or hide borders on maximization, make sure this
> work in any case)

My solution covers both full and vertical titleless maximizations. I'd
be glad if someone tested it with me. It works for me and I already use
it.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/10

------------------------------------------------------------------------
On 2013-06-10T09:28:09+00:00 Konstantin G. Khlebnikov wrote:

I have applied this to xfwm4 4.10.1 from debian/testing and it work like a 
charm.
Patch little bit messy, it would be better to split it into pieces.

screenshot:
https://plus.google.com/105141859736228162791/posts/QpiEk7uf6Ah

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/11

------------------------------------------------------------------------
On 2013-06-10T14:26:35+00:00 Olivier Fourdan wrote:

(In reply to comment #5)
> 
> I couldn't find appropriate EWMH atom to show/hide titles of maximized
> windows. My solution isn't unconditional, it adds new checkbox (initially
> unchecked) to WM tweaks.

True, indeed, I got confused.

But gtk+ has a mechanism for that: "_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED"

https://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkwindow-x11.c#n3472

Would be great to have that as well, so that apps that use this get
undecorated when maximized even if the user has not specified the option
(so we geta consistent behavior with gtk+ apps at least)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/12

------------------------------------------------------------------------
On 2013-07-12T05:19:53+00:00 thesame wrote:

Created attachment 5092
_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED support

Diff against current git master. Must be applied on top of previous
patch.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/13

------------------------------------------------------------------------
On 2013-08-22T23:21:10+00:00 thesame wrote:

Nobody seems to care :(

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/14

------------------------------------------------------------------------
On 2013-09-26T09:16:18+00:00 Christian Hesse wrote:

I do care and I really like it! ;)
This should be merged upstream I think.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/15

------------------------------------------------------------------------
On 2013-11-29T17:28:27+00:00 Cedric Leporcq wrote:

Hello, I've worked on this patch made by Viktor Semykin and I've made some 
improvements and fixes for xfwm4 4.10 and 4.11.
If  you are interested it's available here: 
https://github.com/cedl38/xfwm4-titleless.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/16

------------------------------------------------------------------------
On 2013-11-29T18:07:32+00:00 Cedric Leporcq wrote:

Created attachment 5245
add xfwm4 titleless option for maximized windows - 4.10.1

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/17

------------------------------------------------------------------------
On 2013-11-29T18:10:13+00:00 Cedric Leporcq wrote:

Comment on attachment 5245
add xfwm4 titleless option for maximized windows - 4.10.1

patch for xfwm4 version 4.10.1

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/18

------------------------------------------------------------------------
On 2013-11-29T18:19:17+00:00 Cedric Leporcq wrote:

Created attachment 5246
hide title and top border on maximized features - 4.10.1

Patch for xfwm4 version 4.10.1
Add titleless maximization feature and extra functionalities: 
- Change top border creation for hiding capabilities (add frameTopBorder and 
frameTitle functions)
- Split title-*.xpm into title and top border part if top-3-active.xpm don't 
exist
- add optional top_border_height and top_border_maximize parameters.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/19

------------------------------------------------------------------------
On 2013-11-29T18:26:31+00:00 Cedric Leporcq wrote:

Created attachment 5247
hide title and top border on maximized features - 4.11.0

Patch for xfwm4 version 4.11.0
Add titleless maximization feature and extra functionalities.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/20

------------------------------------------------------------------------
On 2014-01-03T08:57:54+00:00 Christian Hesse wrote:

Created attachment 5292
Screenshot of misrendered decorations

Using the latest patch by Cédric Leporcq now. Works great on most
system, though it interferes with bug 10049 [0]. Uploading a screenshot
of misrendered decorations, please compare with the upload from the
other bug. Any ideas what could have caused this?

https://bugzilla.xfce.org/show_bug.cgi?id=10049

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/22

------------------------------------------------------------------------
On 2014-01-03T13:24:54+00:00 Cedric Leporcq wrote:

Hello Christian,

Can you please tell me witch theme are you using ? I’m wondering if this
bug can be related to a specific theme.

My latest patch have made some changes regarding the theme
implementation to allow top border hiding. Theses changes d’ont affect
theme rendering for most of them. I noticed some glitch on few themes
(like metabox) for very particular reason that can be easily fixed with
theme updates.

(my latest revisions can be found here :
https://github.com/cedl38/xfwm4-titleless)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/23

------------------------------------------------------------------------
On 2014-01-03T15:03:55+00:00 Christian Hesse wrote:

Hello Cédric,

this is a customized version of Curve, but plain Curve from xfwm4-themes
suffers the same issue. Looks like this happens whenever just one
visible pixel in a row...

I do see this in a virtualbox with guest additions installed. Bare metal
with intel hardware in uneffected, so not sure if the is a xfwm4 or
driver problem.

What did you change for Metabox? Perhaps that gives me any idea how to
fix it.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/24

------------------------------------------------------------------------
On 2014-01-03T15:29:20+00:00 Christian Hesse wrote:

Probably worst one is Cruxish... It misses the title entirly.
title-3-(in)?active.xpm is just one pixel wide, so it fits my theory.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/25

------------------------------------------------------------------------
On 2014-01-03T17:24:01+00:00 Cedric Leporcq wrote:

Created attachment 5296
metabox bug

I can’t reproduce yours bugs on my system. To test your theory you can
change the pixmaps wide from 1 pixel to 3 for example with a text
editor. This change does not affect the theme appearance.

For metabox there is a bug in the theme, but only visible with my patch.
To fix it change number 2 by 3 in title_5_active_xpm with a text editor:

"8 21 2 1",
"     c None",
".    c #000000",
"+    c #5B80AD s active_color_1",

"8 21 2 1", should be "8 21 3 1", because there are three colors in this
pixmap

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/26

------------------------------------------------------------------------
On 2014-01-05T14:18:53+00:00 Christian Hesse wrote:

I think my xpm images are ok.

Looks like this only happens when X.org VESA driver is in action (which
is also true for virtualbox guests whith vboxvideo). So possibly we do
not have a xfwm4 bug but a X.org driver one.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/27

------------------------------------------------------------------------
On 2014-11-21T12:58:07+00:00 Landry-o wrote:

*** Bug 7436 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/29


** Changed in: xfwm4
       Status: Unknown => Confirmed

** Changed in: xfwm4
   Importance: Unknown => Wishlist

** Bug watch added: Xfce Bugzilla #10049
   https://bugzilla.xfce.org/show_bug.cgi?id=10049

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/904958

Title:
  xfwm4: top border still present when window is maximized

To manage notifications about this bug go to:
https://bugs.launchpad.net/xfwm4/+bug/904958/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to