------- Comment From [email protected] 2015-02-08 11:54 EDT------- (In reply to comment #24) > Hm, seems like that might make this not work on ppc64le. Could someone > with the hardware please test and confirm? > > Quoting Stefan Bader ([email protected]): > > Now too late but I had noticed that the provided patch #3 missed two > > changes from the upstream patch. Not sure how important those would be: > > > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > > index 1b8efb1..21309b0 100644 > > --- a/src/conf/domain_conf.c > > +++ b/src/conf/domain_conf.c > > @@ -10043,7 +10043,7 @@ virDomainVideoDefaultType(const virDomainDef *def) > > (STREQ(def->os.type, "xen") || > > STREQ(def->os.type, "linux"))) > > return VIR_DOMAIN_VIDEO_TYPE_XEN; > > - else if (def->os.arch == VIR_ARCH_PPC64) > > + else if ARCH_IS_PPC64(def->os.arch) > > return VIR_DOMAIN_VIDEO_TYPE_VGA; > > else > > return VIR_DOMAIN_VIDEO_TYPE_CIRRUS; > > diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c > > index 67cb9ff..d591c18 100644 > > --- a/src/cpu/cpu_powerpc.c > > +++ b/src/cpu/cpu_powerpc.c > > @@ -38,7 +38,7 @@ > > > > VIR_LOG_INIT("cpu.cpu_powerpc"); > > > > -static const virArch archs[] = { VIR_ARCH_PPC64 }; > > +static const virArch archs[] = { VIR_ARCH_PPC64, VIR_ARCH_PPC64LE }; > > > > struct ppc_vendor { > > char *name;
Yes, these two changes are indeed essential. I verified that: 1) These have not been included in the libvirt package shipped with ubuntu 15.04. 2) These are essential to launching guest VMs on ppc64 little endian arch. In fact, I had uploaded a modified patch too at the time, but it seems that got missed. Can these changes be included now ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1396070 Title: Libvirt patches for launching VMs with 'ppc64le' architecture. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1396070/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
