Launchpad has imported 3 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=89476.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2015-03-06T19:34:36+00:00 Killertofu wrote: Created attachment 114095 Patch to fix issue If the command `upower -d` is run while a device with no history is attached, the command can crash with a segfault. Relevant backtrace when compiled from the master branch (f3706d7) with debugging: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff76d8444 in g_variant_unref () from /usr/lib/libglib-2.0.so.0 (gdb) bt #0 0x00007ffff76d8444 in g_variant_unref () from /usr/lib/libglib-2.0.so.0 #1 0x00007ffff7bc27b2 in up_device_get_history_sync (device=0x7ffff0003c70, type=0x7ffff7bd23af "charge", timespec=120, resolution=10, cancellable=0x0, error=0x0) at up-device.c:484 #2 0x00007ffff7bc192d in up_device_to_text_history (device=0x7ffff0003c70, string=0x7ffff0001920, type=0x7ffff7bd23af "charge") at up-device.c:194 #3 0x00007ffff7bc2391 in up_device_to_text (device=0x7ffff0003c70) at up-device.c:375 #4 0x0000000000401d14 in main (argc=1, argv=0x7fffffffe748) at up-tool.c:321 (gdb) This appears to be caused by the fact that if the call to 'up_device_glue_call_get_history_sync' within the 'up_device_get_history_sync' function fails, the 'gva' variable will be left uninitialized. The function later tries to call 'g_variant_unref' on it and fails. A patch which initializes 'gva' to NULL is attached and resolves the issue for me. A similar fix may also be needed for the 'up_device_get_statistics_sync' function (which follows the same pattern of leaving 'gva' uninitialized). Reply at: https://bugs.launchpad.net/ubuntu/+source/mate-power- manager/+bug/1428337/comments/8 ------------------------------------------------------------------------ On 2015-03-13T12:21:20+00:00 Martin Pitt wrote: *** Bug 89514 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/mate-power- manager/+bug/1428337/comments/9 ------------------------------------------------------------------------ On 2015-03-13T12:23:36+00:00 Martin Pitt wrote: I came here from a downstream report/patch, so I didn't take your patch, sorry. Fixed in master now: http://cgit.freedesktop.org/upower/commit/?id=2510148b16 Thanks! Reply at: https://bugs.launchpad.net/ubuntu/+source/mate-power- manager/+bug/1428337/comments/10 ** Changed in: upower Status: Unknown => Fix Released ** Changed in: upower Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1428337 Title: MATE power statistics crashed To manage notifications about this bug go to: https://bugs.launchpad.net/upower/+bug/1428337/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
