Am 08.04.2015 um 11:30 schrieb Oleg Cherkasov:
> Thank you for the patch!  Would you propose it as a fix to official
> Ubuntu repos?
>
Dear Oleg,

of course I would like to have this bug fixed officially. Do I have to 
do something for it or would you arrange all things, that are necessary 
for this (changing source, building binaries or something like that)?

I've reviewed the code of proto_xboard.cc and proto_xboard.h. Now I 
guess that someone just changed the number of bytes to be copied in line 
#1087 to 512 to support long paths without bearing in mind that the 
pointer EngineRunDir may have been allocated with less than these 512 
bytes (it is defined in the proto_xboard.h as char[256]!!!). All other 
references to the variable EngineRunDir have indeed a limitation to the 
256 bytes. So one possibility would be, as my suggestion, was to change 
the line #1087 to
snprintf(EngineRunDir,256,"%s/.eboard/craftylog",global.env.Home.c_str());
and leave all the rest as it ist or to change ALL references of 
EngineRunDir to a value of 512 bytes where necessary to let EngineRunDir 
be longer than 256 bytes.

What do you think?

So I'm looking forward to your answer or feel free to just fix the
bug...

Greetings from Berlin to whereever you live

Lars

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1306419

Title:
  crash if select crafty engine

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/eboard/+bug/1306419/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to