Thanks for your comment, Sebastien! Let me say a few words about the reason for involving the user_get_property() function in the first place.
In addition to generating lists of available options, the GUIs for setting language and regional formats asks accountsservice about the current value. Packages which rely on accountsservice in this respect are: - language-selector - unity-control-center (for User Accounts) - gnome-control-center (for both Region & Language and User Accounts) - lightdm (for lightdm-gtk-greeter) - ubuntu-system-settings So far, as long as the user has not set some other value but the system default, and since accountsservice does not store system defaults, accountsservice has generated the value on the fly. The code for doing so is somewhat expensive, and - as mentioned in the bug description - user_get_property() is called frequently. In the light of this, changing it so the user config is saved (based on system default) is a way to improve the efficiency. If we would take the other route, and let accountsservice respond with the empty string, we would mess it up in several places. Please note that I'm not asking for a detailed code review. I merely ask if you are strongly against the approach (saving user settings based on system defaults). After this explanation, I hope you are not. :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1443178 Title: Accounts Service always relies on language fallback if never set by the user To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1443178/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
