Public bug reported:

[Description]

The stop method is not working properly. I removed the --oknodo &&
--quiet and is returning (No /usr/sbin/haproxy found running; none
killed)

I think this is a regression caused by the incorporation of this lines
on the stop method:

+       for pid in $(cat $PIDFILE); do
+               start-stop-daemon --quiet --oknodo --stop \
+                       --retry 5 --pid $pid --exec $HAPROXY || ret=$?

root@juju-machine-1-lxc-0:~# service haproxy status
haproxy is running.
root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root        1513     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
root@juju-machine-1-lxc-0:~# service haproxy restart
 * Restarting haproxy haproxy
   ...done.
root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root        2277     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
root@juju-machine-1-lxc-0:~# service haproxy restart
 * Restarting haproxy haproxy
   ...done.
root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root        2523     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
root@juju-machine-1-lxc-0:~# service haproxy stop
 * Stopping haproxy haproxy
   ...done.
root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root        2584     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy
root@juju-machine-1-lxc-0:~# service haproxy start
 * Starting haproxy haproxy
   ...done.
root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
haproxy     2591       1  0 14:34 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root        2610     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy

** Affects: haproxy (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: sts

** Description changed:

  [Description]
  
  The stop method is not working properly. I removed the --oknodo &&
  --quiet and is returning (No /usr/sbin/haproxy found running; none
  killed)
  
- root@juju-machine-1-lxc-0:~# service haproxy status                           
                                                                                
                                                                                
                                     
+ I think this is a regression caused by the incorporation of this lines
+ on the stop method:
+ 
+ +     for pid in $(cat $PIDFILE); do
+ +             start-stop-daemon --quiet --oknodo --stop \
+ +                     --retry 5 --pid $pid --exec $HAPROXY || ret=$?
+ 
+ root@juju-machine-1-lxc-0:~# service haproxy status
  haproxy is running.
- root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy                             
                                                                                
                                                                                
                                     
+ root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        1513     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
- root@juju-machine-1-lxc-0:~# service haproxy restart                          
                                                                                
                                                                                
                                     
-  * Restarting haproxy haproxy
-    ...done.
+ root@juju-machine-1-lxc-0:~# service haproxy restart
+  * Restarting haproxy haproxy
+    ...done.
  root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2277     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root@juju-machine-1-lxc-0:~# service haproxy restart
-  * Restarting haproxy haproxy
-    ...done.
+  * Restarting haproxy haproxy
+    ...done.
  root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2523     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root@juju-machine-1-lxc-0:~# service haproxy stop
-  * Stopping haproxy haproxy
-    ...done.
+  * Stopping haproxy haproxy
+    ...done.
  root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2584     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy
  root@juju-machine-1-lxc-0:~# service haproxy start
-  * Starting haproxy haproxy
-    ...done.
- root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy                             
                                                                                
                                                                                
                                     
+  * Starting haproxy haproxy
+    ...done.
+ root@juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2591       1  0 14:34 ?        00:00:00 /usr/sbin/haproxy -f 
/etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2610     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1477198

Title:
  Stop doesn't works on Trusty

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1477198/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to