Public bug reported:

While dumping a 6TB ext4 filesystem onto a single file, I saw reports
such as

after most of the filesystem had been dumped. Obviously this pointed to
an integer overflow, and sure enough, the global variable
"blockswritten" is an int, not a long long. This should fix it, although
I don't have time to test it with a 6TB filesystem right now :)

$ diff dump/main.c dump/main.c.orig
136c136
< long long blockswritten;/* number of blocks written on current tape */
---
> int   blockswritten;  /* number of blocks written on current tape */

Also: any idea why the original code uses signed numbers? blockswritten,
bytes_written, and tapesize should all be unsigned long long.

** Affects: dump (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1478265

Title:
  dump  0.4b44 incorrectly reports percentages when dumping to file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dump/+bug/1478265/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to