As I could not find the 3rd patch you said you wanted me to add in, I have added the two in the bug report: https://bugzilla.gnome.org/show_bug.cgi?id=753181 There seem to only be 2 extra patches needed to fix the bugs. If there is another patch which needs to be included, please let me know and I'd be happy to do so. I have generated a new debdiff with all 5 patches in it. And also updated the description, although my information on reproducing the last 2 bugs is a little vague because I have not actually experienced them as I would need to test the other patches in a testing environment to get the 2 other new bugs, and I have not. I have now also attached the new debdiff.
** Description changed: [Impact] - There are three patches in this one fix. So there are three bugs which - are fixed: + There are five patches in this one fix. So there are five bugs which are + fixed: - Bug [1]: If the "Next" button ever gets set to "Sign In", it won't get reset to next until the next question asked by pam. - Bug [2]: Normally the user isn't allowed to proceed passed the username question until they've filled it in. To ensure this, the authprompt code desensitizes the next button when the number of characters change to zero. Unfortunately it fails to desensitize the next button up front when the entry starts out empty. - Bug [3]: Users are not allowed to cancel if the verification has not started yet and they are typing in their username. + - Bug [4]: If the authPrompt gets reset for some other reason in the + interim, this would mean that we don't fade the authentication prompt + back in when it is needed. + + - Bug [5]: The user session will crash when the login screen is + reactivated due to the fact that the previous the user verifier has not + been cleared. + These are rather important things to be fixed as they make the login process more confusing and difficult. How the bugs are fixed: - Bug [1] fix: Reset "Next" button to "Next" when asking for username. - Bug [2] fix: Disallow the user to press "Next" when the username field is empty up front. - Bug [3] fix: authPrompt no longer ignores the request to cancel before a user has started verification and is still typing in their username. + + - Bug [4] fix: loginDialog now only skips the fade-in if we have already + fadded-in. It now also only skips resetting if we have already reset. + + - Bug [5] fix: We now make sure that once the user verifier has + completed its job (of user verification) that it gets cleared so that it + does not get in the way later. [Test Case] - Reproduce Bug [1]: On the first login screen (or log out - not lock), click "Sign In?", then before doing anything else click "Sign In", if the button allows you to press it and is not greyed out, then you have successfully reproduced this bug. - Reproduce Bug [2]: On the locked screen click "Sign In?", then before doing anything else press "Cancel". If nothing happens, you have successfully reproduced this bug. - Reproduce Bug [3]: On the locked screen click "Sign In?", then in the username field, start entering your username (or any text), then instead of pressing "Next", press "Cancel", if nothing happens then you have successfully reproduced this bug. + - Reproduce Bug [4]: + + Go to the login screen (or locked screen), reset the authentication + prompt before you have reached "VERIFICATION_SUCCEEDED", and if you see + that the prompt does not fade back in, then you have successfully + reproduced this bug. + + - Reproduce Bug [5]: + + After you have logged in, go back to the login screen, if the user + session crashes, then you have successfully reproduced this bug. + [Regression Potential] - 1. You may notice that we only fade the authentication prompt back in if - the auth prompt status is "VERIFICATION_SUCCEEDED". It's possible for it - to be "NOT_VERIFYING" if the authprompt gets reset for some other reason - in the interim. - - 2. You may also notice that the user session crashes when the login - screen is reactivated. + As these patches have already been put to practical use in the upstream + version, and the patches which have been put to use in this version, + have originated from those patches, I would say that the risk of + regression is minimal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
