Comment on attachment 118426
Increase the retry interval to 5 seconds.

This breaks the timeout value given by the user. In open_message_ready()
we'll do a ctx->timeout--; if we got a timeout error, so that we can
retry. Instead of ctx->timeout--; there should be a ctx->timeout-=5
there, and along with that: make timeout a gint (not guint) and also
don't do the (ctx->timeout) check, and instead do (ctx->timeout > 0)

Also, better #define RETRY_TIMEOUT_SECS 5 and use the symbol everywhere.

Could you update the patch and retest?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1441095

Title:
  novatel: improve probing for Dell branded modems

To manage notifications about this bug go to:
https://bugs.launchpad.net/modemmanager/+bug/1441095/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to