Public bug reported:

gjs breaks API/ABI from 1.43.3 to 1.44.0

diff --git a/gi/interface.h b/gi/interface.h
index cdb41ab..70e71a7 100644
--- a/gi/interface.h
+++ b/gi/interface.h
@@ -33,7 +33,9 @@ G_BEGIN_DECLS
 
 JSBool gjs_define_interface_class (JSContext       *context,
                                    JSObject        *in_object,
-                                   GIInterfaceInfo *info);
+                                   GIInterfaceInfo *info,
+                                   GType            gtype,
+                                   JSObject       **constructor_p);
 
 JSBool gjs_lookup_interface_constructor (JSContext     *context,
                                          GType          gtype,
diff --git a/gjs/compat.h b/gjs/compat.h
index b5b617f..236ce60 100644
--- a/gjs/compat.h
+++ b/gjs/compat.h
@@ -77,8 +77,8 @@ gjs_##name##_constructor(JSContext  *context,           \
  * be at the very top.
  */
 #define GJS_NATIVE_CONSTRUCTOR_VARIABLES(name)          \
-    JSObject *object = NULL;                            \
-    jsval *argv G_GNUC_UNUSED = JS_ARGV(context, vp);
+    JSObject *object = NULL;                                            \
+    JS::CallArgs argv G_GNUC_UNUSED = JS::CallArgsFromVp(argc, vp);
 
 /**
  * GJS_NATIVE_CONSTRUCTOR_PRELUDE:
@@ -101,7 +101,7 @@ gjs_##name##_constructor(JSContext  *context,           \
  * successfully.
  */
 #define GJS_NATIVE_CONSTRUCTOR_FINISH(name)             \
-    JS_SET_RVAL(context, vp, OBJECT_TO_JSVAL(object));
+    argv.rval().set(OBJECT_TO_JSVAL(object));
 
 /**
  * GJS_NATIVE_CONSTRUCTOR_DEFINE_ABSTRACT:

** Affects: gjs (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: gjs (Ubuntu Xenial)
     Importance: Undecided
         Status: New


** Tags: block-proposed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1511253

Title:
  1.44.0 breaks API/ABI without transitioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gjs/+bug/1511253/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to