e0f03e87fc6f27a8af9896f430f2945b3b1664c0 is the first bad commit
commit e0f03e87fc6f27a8af9896f430f2945b3b1664c0
Author: Heiner Kallweit <hkallwe...@gmail.com>
Date: Wed Dec 16 07:33:22 2015 +0100
PNP: respect PNP_DRIVER_RES_DO_NOT_CHANGE when detaching
I have a device (Nuvoton 6779D Super-IO IR RC with nuvoton-cir driver)
which works after initial boot but not any longer if I unload and
re-load the driver module.
Digging into the issue I found that unloading the driver calls
pnp_disable_dev although the driver has flag PNP_DRIVER_RES_DO_NOT_CHANGE
set. IMHO this is not right.
Let's have a look at the call chain when probing a device:
pnp_device_probe
1. attaches the device
2. if it's not active and PNP_DRIVER_RES_DO_NOT_CHANGE is not set
it gets activated
3. probes driver
I think pnp_device_remove should do it in reverse order and also
respect PNP_DRIVER_RES_DO_NOT_CHANGE. Therefore:
1. call drivers remove callback
2. if device is active and PNP_DRIVER_RES_DO_NOT_CHANGE is not set
disable it
3. detach device
The change works for me and sounds logical to me.
However I don't know the pnp driver in detail so I might be wrong.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
:040000 040000 8b208d9346c4a3948dbf8cde3083cc9c8adb026d
2f91a8f9fcf0699cc5d8ea3bc4322d8f1724e67b M drivers
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1509751
Title:
Kernel disabling serial port ttyS0 again
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1509751/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
