Thank you for providing these packages for upload. Here is some
preliminary feedback regarding the src package. Further feedback on the
other packages to follow later.
Feedback is separated into issues that must be resolved before accepting
the package into the Canonical partner archive, and general issues that
it would be good to have fixed but it's not required to fix.
The following issues are must-fix for this package's inclusion in the archive:
- The name 'src' is confusingly short and is likely to collide with other uses
of this abbreviation. Please choose a different name for this package, for
both source and binary. I would suggest 'ibm-src'.
- The package declares a pre-depends (on ksh). pre-depends are only to be used
for packages with preinst scripts. This should be dropped.
- debian/compat declares debhelper compat level 5, which is obsolete. Please
use debhelper compat level 9 or better. (In particular, there is no reason to
use compat level 5 together with a debian/rules based on the dh(1) command.)
- debian/conffile should not exist. The conffile information should be
automatically calculated by debhelper.
- There is a wrong explanation in debian/rules for overriding dh_shlibdeps:
# we are not allowed to modify binary files
dh_shlibdeps does not modify any upstream files; it merely examines those
binaries to calculate correct dependencies. This aligns with a warning message
output by lintian:
W: src source: package-depends-on-hardcoded-libc src depends
The package should instead use ${shlibs:Depends} in debian/control and avoid
overriding dh_shlibdeps in debian/rules.
- The package declares a Provides: for its own name. This should be dropped.
- The override_dh_installman target tries to run a shell script without using
line continuation, so creates files in the wrong directory.
- With the exception of debian/rules, files in the debian/ packaging directory
should not be marked executable in the source package.
- debian/postinst is creating symlinks in usr/bin and usr/lib at package
install time. It should not; these symlinks should be shipped in the binary
package, so that the links are clearly shown as owned by the package.
- The postinst creates a directory under /var/adm, which is not part of the
FHS. For compatibility with unmodifiable binaries that reference such paths,
it's permissible for a package to create a symlink here; but the target of that
symlink needs to point to a standard directory so that the files are handled
correctly for such things as backup policies.
- The postinst changes the ownership of /usr/lib/SRC/man/lssrc.1.gz to bin:bin.
This makes no sense; manpages on Ubuntu systems should all be owned by
root:root.
- The following lintian errors are overridden, but should instead be addressed:
O: ibm-src: maintainer-script-ignores-errors postinst
O: ibm-src: maintainer-script-ignores-errors postrm
O: ibm-src: maintainer-script-ignores-errors prerm
O: ibm-src: executable-is-not-world-readable sbin/srcd 0750
O: ibm-src: executable-is-not-world-readable sbin/srcmstr 0750
The following issues would also be good to fix:
- The 'homepage' field in debian/control should point to a URL where the end
user can find information online about the package, including other downloads.
It is unlikely that 'www.ibm.com' fits this purpose for this one particular
piece of IBM software.
- lintian outputs warnings about incorrect use of debhelper. For this package
each of these changes is a no-op for the resulting binary package, so fixing
these is not required.
W: ibm-src source: debhelper-but-no-misc-depends ibm-src
W: ibm-src source: maintainer-script-lacks-debhelper-token debian/postinst
W: ibm-src source: maintainer-script-lacks-debhelper-token debian/postrm
W: ibm-src source: maintainer-script-lacks-debhelper-token debian/prerm
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1537760
Title:
[needs-packaging] RSCT
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1537760/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
