Thanks Seth. I've submitted upstream a fix for get_fd_and_media_path and the various shellcheck fixes. I expect they should be merged for the next fwupdate release. https://github.com/rhinstaller/fwupdate/pull/45/commits
I'm unsure if fflush(fout) is needed between fputc() and fclose(). I think that's better answered by upstream. https://github.com/rhinstaller/fwupdate/issues/46 The shellcheck fixes in debian/ I've commited to debian-next (which will be uploaded on the next fwupdate release). http://anonscm.debian.org/cgit/uefi/fwupdate.git/log/?h=debian-next Let me know if anything called out is a blocker for promotion, otherwise expect fixes for all at next fwupdate release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1508926 Title: [MIR] fwupdate To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwupdate/+bug/1508926/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
