>From looking at the patch, I have a few comments/questions:
- Don't you have to name the service exactly like the init script,
apache-htcacheclean, to make sure it overrides the init script?
- You should depend on network-online.target . Apache may not start if
some IPs are not yet configured.
- I would not recommend graceful stop as default stop action. We had
that in the init script for a while and it didn't work too well. From
the changelog:
Make the init script use normal 'stop' instead of 'graceful-stop' again:
With graceful-stop, it can take a long time until all child processes have
closed their listening sockets and there is no way for the init script to
know when it is save to start apache again. This could make the restart of
apache fail.
- You don't seem to support multiple instances, yet. Why do you call the
service [email protected], then?
But I haven't tested it, yet.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1566519
Title:
Please add native systemd units
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1566519/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
