- Same subscriber issue Steve noticed
- Needs MIR for golang-github-azure-go-pkcs12-dev and
golang-github-azure-go-autorest-dev
- I'm not excited about the test skips in debian/rules:
# core/http_test and core/http/httputil don't compile properly
# storage needs "ACCOUNT_NAME" to test against remote services
DH_GOLANG_EXCLUDES='core/http core/tls storage' dh_auto_test
In storage, I'd rather we just patched storage/client_test.go to use
c.Skip instead of c.Fatal for its error about ACCOUNT_NAME. That way we
can test the other tests in storage/ that don't require ACCOUNT_NAME
(and any new added tests in future in that subdir).
Likewise, I'm nervous about the solution to core/tls test failures being
just skipping them. The failure is because this package is shipping a
fork of core/tls, which is never super great. In this case, they are
doing so because of https://github.com/golang/go/issues/5742 which means
golang's copy can't deal with Azure. So OK, they have a good reason.
But I'm not pumped with our solution to outdated forked code being,
"let's just stop running tests."
Can we investigate whether the test failure indicates a real problem /
how much work an updated core/tls is / whether we can skip specific
tests rather than the entire core/tls subdirectory?
Likewise, what's the story with core/http? Its test code doesn't
compile apparently. Do we know why? And are we shipping a forked copy
for the same reason as above or something else?
** Changed in: golang-github-azure-azure-sdk-for-go (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1568164
Title:
[MIR] golang-github-azure-azure-sdk-for-go-dev
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-github-azure-azure-sdk-for-go/+bug/1568164/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
