This is the very definition of racy.

It appears to me that the point of the post-start is to make sure
libvirt is ready, no matter how long it takes.  If libvirt actually
fails to start, upstart should catch that and mark it failed and abort
post-start, is that right?  If not, then we should complicate the loop
in the post-start to make that logic happen.

But my point is that having a timeout there at all is wrong - we are
waiting for the socket to be ready, not trying to catch failure to
start.  So we should effectively wait forever for either libvirt to be
ready, or to have failed to start.  No guessing at timeouts here.

** Changed in: libvirt (Ubuntu)
     Assignee: (unassigned) => Edward Hope-Morley (hopem)

** Changed in: libvirt (Ubuntu)
   Importance: Undecided => High

** Changed in: libvirt (Ubuntu)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1571209

Title:
  Sockfile check retries too short for a busy system boot

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1571209/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to