Public bug reported:

I was trying to use snapcraft to snap flight-of-the-amazon-queen. To my
dismay I found that scummvm crashes on initialization. Some debugging in
gdb lead me to a bug libsdl1.2 in get_progname(). The error case, which
doens't occur outside snappy confinement cause the function to return
null, leading to a crash when the data is subsequently used without
checks.

I've patched the function to return "unknown" (as it does in other
cases) and tested that this works correctly. The debian/patches file
patch is attached. I would like to SRU this fix into xenial given the
high impact of snappy and the negative effect this bug has for each
application using SDL.

[Test Case]
TBD (snapcraft.yaml with flight-of-the-amazon-queen)

[Regression Potential]
None, this fixes a crash that occurs only on snappy. The code in question is 
clearly broken, returning NULL from a function that never returns NULL 
otherwise.


ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: libsdl1.2debian 1.2.15+dfsg1-3
ProcVersionSignature: Ubuntu 4.4.0-21.37-generic 4.4.6
Uname: Linux 4.4.0-21-generic x86_64
ApportVersion: 2.20.1-0ubuntu2
Architecture: amd64
CurrentDesktop: GNOME
Date: Wed May  4 01:40:40 2016
InstallationDate: Installed on 2016-03-01 (63 days ago)
InstallationMedia: Ubuntu 15.10 "Wily Werewolf" - Release amd64 (20151021)
SourcePackage: libsdl1.2
UpgradeStatus: No upgrade log present (probably fresh install)

** Affects: libsdl1.2 (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: amd64 apport-bug xenial

** Patch added: "Tested fix for the crash"
   
https://bugs.launchpad.net/bugs/1577986/+attachment/4654854/+files/dont-crash-on-snappy

** Description changed:

  I was trying to use snapcraft to snap flight-of-the-amazon-queen. To my
  dismay I found that scummvm crashes on initialization. Some debugging in
  gdb lead me to a bug libsdl1.2 in get_progname(). The error case, which
  doens't occur outside snappy confinement cause the function to return
  null, leading to a crash when the data is subsequently used without
  checks.
  
  I've patched the function to return "unknown" (as it does in other
  cases) and tested that this works correctly. The debian/patches file
  patch is attached. I would like to SRU this fix into xenial given the
  high impact of snappy and the negative effect this bug has for each
  application using SDL.
+ 
+ [Test Case]
+ TBD (snapcraft.yaml with flight-of-the-amazon-queen)
+ 
+ [Regression Potential]
+ None, this fixes a crash that occurs only on snappy. The code in question is 
clearly broken, returning NULL from a function that never returns NULL 
otherwise.
+ 
  
  ProblemType: Bug
  DistroRelease: Ubuntu 16.04
  Package: libsdl1.2debian 1.2.15+dfsg1-3
  ProcVersionSignature: Ubuntu 4.4.0-21.37-generic 4.4.6
  Uname: Linux 4.4.0-21-generic x86_64
  ApportVersion: 2.20.1-0ubuntu2
  Architecture: amd64
  CurrentDesktop: GNOME
  Date: Wed May  4 01:40:40 2016
  InstallationDate: Installed on 2016-03-01 (63 days ago)
  InstallationMedia: Ubuntu 15.10 "Wily Werewolf" - Release amd64 (20151021)
  SourcePackage: libsdl1.2
  UpgradeStatus: No upgrade log present (probably fresh install)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1577986

Title:
  SDL 1.2 crashes on snappy, breaks scummvm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libsdl1.2/+bug/1577986/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to