** Description changed:

  The "strip" phase name is not great. It's not actually stripping.. it's
  the phase that copies the content into the snap directory, as I
  understand it. So it's the opposite of stripping (although I understand
  where the motivation comes from). See how this command makes little
  sense, for example:
  
-     snapcraft clean --step=strip
+     snapcraft clean --step=strip
  
  So it might be better named as something like "cast", or "shape", or
  "form". I'd check with Mark for the best word here.
+ 
+ [Impact]
+ 
+  * One of the snapcraft commands is confusing.
+ 
+  * The change is backwards compatible, so anything that's relying on
+ strip will still work.
+ 
+ [Test Case]
+ 
+  * Run snapcraft strip
+  * Check that you get a deprecation message.
+  * Clean
+  * Run snapcraft prime
+  * Check that the results are the same, without deprecation message.
+ 
+ [Regression Potential]
+ 
+  * This could affect the strip command.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to