A few minor comments: - The upstream version is 2016.06. But citrain already appends the date as part of the version. So unless you plan to make a habit of updating the upstream version, you may eventually get to versions like 2016.06+17.10.20180705, which has three different dates in it, all different. This isn't a *problem*, just pointing it out. May become confusing.
- Vcs-Git in debian/control should be "https://git.launchpad.net/repowerd"; (or lp:repowerd, if git understands that?) - It is more proper for the powerd dummy package to be "Arch: any" since it points at an "any" package. - I see REPOWERD_DISABLE_TIME_SENSITIVE_TESTS=ON in debian/rules. Is there something that does run the time sensitive tests? CI Jenkins maybe? This might be a good spot to suggest adding a dep8 test that runs the full test suite. - dh_installinit seems to be a little confused? It inserts code into postinst and prerm to stop and start the init.d job. But repowerd only installs an upstart job and a systemd job... Otherwise the packaging seems fine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1599271 Title: repowerd needs packaging To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1599271/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
