Thank you for updating the package! A native package is fine here. I have one thing I'd like you to fix before I'll upload:
Your debian/copyright doesn't quite follow the format. 1. "The last paragraph that matches a particular file applies to it. More general paragraphs should therefore be given first, followed by more specific overrides." In other words, the Files: * section should be the first section not the last. 2. If you downloaded the file from a particular URL that lists the copyright, it might be nice to include it in a Comment section so that it's easier for someone that wanted to verify the file's license. 3. The names of Files in d/copyright need to match the actual file names. Therefore a section could look something like: Files: beauty_of_mandarins_by_erwan_hesry.jpg Copyright: Erwan Hesry Comment: http://... License: CC0 4. I think you should keep the Files: * copyright holders from ubuntu- wallpapers (Nathan McCallum, etc.) since they originally wrote the scripts included in the source but feel free to add your name to the list. Here's a few optional notes: 1. In debian/rules, the export DPKG_GENSYMBOLS_CHECK_LEVEL=4 is unnecessary since this package doesn't contain any shared libraries so it doesn't use symbols. (Yes I see that the ubuntu-wallpapers package does this and #1 above.) 2. Maybe you should regenerate po/budgie-wallpapers.pot 3. Did you see the contest/ folder in ubuntu-wallpapers? It adds a special wallpaper (identified in the GNOME Settings app by a small clock in the bottom right corner) that automatically rotates the listed wallpapers every 30 min. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
