On Wed, 2016-08-17 at 19:21 +0000, Michael Terry wrote:
> - Needs a team bug subscriber. Maybe phablet-team or unity-api-team?
Right. Subscribed.
> - For a package built with Go (as pay-service is), it needs to use
> dh-
> golang and "Built-Using: ${misc:Built-Using}" in its control
> file. The
> 3rd party packages are all bundled in too, which is bad. You should
> use
> golang-github-gosexy-gettext-dev instead of bundling
> github.com/gosexy/gettext for example.
The package isn't only golang. Isn't Built-Using added automatically? I
agree the bundling is not ideal, but none of these things were packaged
when we rewrote the service in golang, and it wasn't really clear how
such things should be packaged, as golang doesn't have dynamic libs, so
the only option at the time was to vendorize things in the source tree.
I'm happy to look at using packaged deps instead of bundled source, but
I think this probably shouldn't block the MIR. Can you file a bug about
the bundled source?
I don't think it's possible to switch to dh-golang (would require
significant changes to how the package as a whole is built, and make it
no longer developer-friendly), but I think I maybe misunderstood how
Built-Using works when I saw that e-mail for build deps in universe
mentioning it. I thought it was automatic. If it's not, please file a
bug about Built-Using missing and I'll add it to the control.
> - Not a blocker, but bad practice: "libpay2: package-name-doesnt-
> match-
> sonames libpay2.0.0" You probably want the library to include a
> symlink
> for just "libpay.so.2" pointing at "libpay.so.2.0.0" (compare
> contents
> of libpay2 with libparted2).
Hmm, indeed this looks like probably a bug in the packaging that's just
been there forever. Can you file a bug for this? Should be a trivial
fix at least.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1614202
Title:
[MIR] pay-service
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pay-service/+bug/1614202/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
