Hm that's a bummer. Those tests *could* be written much better for automated use.
1) They could be skipped if an env like NO_MANUAL_TESTS was set. 2) They could be separated out into a separate make target. 3) The tests could require root and restart ofono themselves. 4) They could use dbusmock like you suggest. 5) Something I'm not thinking of. As for /phonesim, that just means they need ofono-phonesim installed. Our autopkgtest control file could make sure that is installed for the tests. But yeah. Clearly the tests are not yet ready for automated use and we aren't in a position to improve upstream immediately. We could do a quick-fix by patching to skip the tests that require a restart and using ofono-phonesim in a autopkgtest. That would give us tests without much effort, I'd hope. As for the bug subscriber, I see you added ~system-settings-touch. That's fine, but ideally we'd have a team from [1]. We could add ~system-settings-touch to that list, but maybe another team there would also make sense to subscribe? [1] http://bazaar.launchpad.net/~ubuntu-archive/ubuntu-archive- tools/trunk/view/head:/package-subscribers#L107 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1612702 Title: [MIR] libqofono To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqofono/+bug/1612702/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
