@Eric -- I am concerned about the effect of some of these changes on
translations.  For example the below will make the format string a new
translatable and therefore will not be translated for non english
locales.  If we simply replaces MNTTAB with "/etc/mtab" the translatable
string would be unchanged:

+               (void) fprintf(stderr, gettext(
+-                  "filesystem '%s' was mounted, but %s "
++                  "filesystem '%s' was mounted, but /etc/mtab "
+                   "could not be opened due to error %d\n"),
+-                  dataset, MNTTAB, errno);
++                  dataset, errno);

There are a few like that.

Also as you are changing MNTTAB is there any reason not to be using that
here?

+-              (void) fprintf(stderr, gettext("warning: %s not in mtab\n"),
+-                  path);
++              (void) fprintf(stderr, gettext("warning: %s not in"
++                  "/proc/self/mounts\n"), path);

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1607920

Title:
  zfs services fail on firstboot if zfs-utils is integrated into the
  deployment image

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sysvinit/+bug/1607920/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to