Hi, all changes are to the Ubuntu only bits - so that part is ok until we merge and reduce further Delta.
Reviewing your latest diff I don't like that the system service should fail if SMT is not set. Especially since it exits before making any of its usual adjustments which is as TL;DR to apply anything in /etc/default/qemu-kvm If one on power would run that, see the service failing, fix up SMT at runtime he could start kvm guests but not have the config applied e.g. ksm config and hugepage checks. That said what would you think of chaning the init script portion of this to something like this for the message: logger -t qemu-kvm "Error: You must disable SMT if you want to run QEMU/KVM on ppc64le archtecture" logger -t qemu-kvm "In order to disable SMT, run: # ppc64_cpu --smt=off"!" And remove the exit 1 in there to let it still continue with the service. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1638329 Title: Improve qemu message when SMT != off To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
