To those of you who are concerned with this message '/etc/modprobe.d is
not a file', note that this message does not reflect an error. It is
simply a wrongly placed and mis-worded message in function
"is_module_blacklisted" in gpu-manager.c However, this does not address
the situation of incorrectly loaded/unloaded modules for video card
changes, which I am scanning the code for. (I am not a developer...)

The line containing this message should be deleted, AND the following
line added immediately after the '    if (dry_run) {' line in the same
function :

        fprintf(stderr, "In dry_run mode(test), therefore we are not
using %s directory \n", modprobe_d_path);


The resulting function code should be as follows :

static bool is_module_blacklisted(const char* module) {
    _cleanup_free_ char *match = NULL;
    char command[100];

    /* It will be a file if it's a test */
    if (dry_run) {

        fprintf(stderr, "In dry_run mode(test), therefore we are not
using %s directory \n", modprobe_d_path);

        snprintf(command, sizeof(command),
                 "grep -G \"blacklist.*%s[[:space:]]*$\" %s",
                 module, modprobe_d_path);

        if (exists_not_empty(modprobe_d_path))
            match = get_output(command, NULL, NULL);
    }
    else {
#        fprintf(stderr, "%s is not a file\n", modprobe_d_path);
        snprintf(command, sizeof(command),
                 "grep -G \"^blacklist.*%s[[:space:]]*$\" %s/*.conf",
                 module, modprobe_d_path);

        match = get_output(command, NULL, NULL);
    }

    if (!match)
        return false;
    return true;
}

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1369216

Title:
  gpu-manager: /etc/modprobe.d is not a file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1369216/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to