Hi Scott,

This looks good to me, although I did notice three changes that I'd
expect to be documented in debian/changelog:

debian/patches/CVE-2015-5144.patch is updated in a way that looks
reasonable.

debian/patches/CVE-2015-596x.patch has a change that seems a little
gratuitous. Was this intentional, and/or am I mistaken?

debian/patches/file-encoding.diff is updated in a way that looks
reasonable.

Did you intend to update these, or did the updates come from somewhere
else?

Do you have an opinion on quilt refreshes? These seem a little
gratuitous too, adding a bunch of noise that makes it harder to spot
real changes. https://wiki.debian.org/UsingQuilt recommends "-p ab --no-
timestamps --no-index" and I prefer to see only quilt refreshes where
they are needed to reduce review diff noise.

I appreciate that you've been doing this kind of thing far longer than I
have, so if it is all intentional, then +1 to accept to Trusty - just
let me know.

Thanks!

** CVE added: http://www.cve.mitre.org/cgi-
bin/cvename.cgi?name=2015-5144

** Changed in: python-django (Ubuntu)
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1644346

Title:
  SRU update Trusty to Python Django 1.6.11

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-django/+bug/1644346/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to