Hello Mattia,

> For the uploads: I'm always kinda ick to upload a package introducing
a delta from debian, but well...

Well, you gotta fix what you gotta fix =).

> What I don't like are the changelogs: you're barely saying what you
did, just listing the name of the patches you added and related bugs.
I'd like to see "Add patch <name> to fix <problem>. LP: #xxxxx". This
tends to be particularly important for SRUs, where users actually go
reading the changelogs to see what they are doing to their stable
installation and figure whether the changes affects them.

I can definitely add more information if you would like. You can see
that the patches are really well explained. Some maintainers prefer a
specific format in changelog, some others. I usually use this one but I
do agree it doesn't cause any harm to add more information.

> In the xenial debdiff, you have an invalid Bug-Debian in 0007-Fix-
IPv6-bind.patch.

Tks for reviewing it, will upload a new one shortly.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1640919

Title:
  pcs cluster setup hangs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to